Add ability to color SegmentioCell objects based on position, not current state #125
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there interest for merging this into the main line of Segmentio? |
jordanpwood
force-pushed
the
feature/item_color
branch
from
ac80b05
to
d6d4928
Compare
Jamonek
approved these changes
Sep 17, 2019
|
Just another vote for getting this merged into the master branch! |
|
Another vote here! |
|
Hi @Yalantis , think this could get merged into the master branch? It would be really nice to have this ability in the main package, so we can stop using our fork. Thank you! |
|
@PravdaEvgen any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the ability to both tint images and color text that shows up in SegmentioCell objects based on their position. This PR adds
overrideTextColorandimageTintColorproperties to SegmentioItem objects, and colors them appropriately in the SegmentioCell object. These new parameters are optional when initializing a SegmentioItem object.