Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu 0.20, imgui 0.12, winit 0.29 #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

benmkw
Copy link
Contributor

@benmkw benmkw commented May 10, 2024

based on #107

imgui-rs released 0.12 which fixed some dependency issues

I don't use imgui that often anymore but would still like to update https://github.com/benmkw/imnodes-rs just because some people use it from time to time and it will help to keep at least the basics working.

For others reading this I would recommend checking out egui if that may be an option.

@benmkw
Copy link
Contributor Author

benmkw commented May 10, 2024

I can't do much about the cargo deny error

syn v1.0.109
├── com_macros v0.6.0 (proc-macro)
│   └── com v0.6.0
│       └── hassle-rs v0.11.0
│           └── wgpu-hal v0.20.0
│               ├── wgpu v0.20.0
│               │   └── imgui-wgpu v0.24.0 (/Users/benediktmandelkow/gits/forks/imgui-wgpu-rs)
│               └── wgpu-core v0.20.0
│                   └── wgpu v0.20.0 (*)
└── com_macros_support v0.6.0
    └── com_macros v0.6.0 (proc-macro) (*)
syn v2.0.61
├── bytemuck_derive v1.6.0 (proc-macro)
│   └── bytemuck v1.15.0
│       ├── image v0.25.1
│       │   [dev-dependencies]
│       │   └── imgui-wgpu v0.24.0 (/Users/benediktmandelkow/gits/forks/imgui-wgpu-rs)
│       ├── imgui-wgpu v0.24.0 (/Users/benediktmandelkow/gits/forks/imgui-wgpu-rs)
│       ├── tiny-skia v0.11.4
│       │   └── sctk-adwaita v0.8.1
│       │       └── winit v0.29.15
│       │           └── imgui-winit-support v0.12.0
│       │               [dev-dependencies]
│       │               └── imgui-wgpu v0.24.0 (/Users/benediktmandelkow/gits/forks/imgui-wgpu-rs)
│       │           [dev-dependencies]
│       │           └── imgui-wgpu v0.24.0 (/Users/benediktmandelkow/gits/forks/imgui-wgpu-rs)
│       ├── tiny-skia-path v0.11.4
│       │   └── tiny-skia v0.11.4 (*)
│       └── winit v0.29.15 (*)
│       [dev-dependencies]
│       └── imgui-wgpu v0.24.0 (/Users/benediktmandelkow/gits/forks/imgui-wgpu-rs)
├── foreign-types-macros v0.2.3 (proc-macro)
│   └── foreign-types v0.5.0
│       ├── core-graphics v0.23.2
│       │   └── winit v0.29.15 (*)
│       └── metal v0.28.0
│           └── wgpu-hal v0.20.0
│               ├── wgpu v0.20.0
│               │   └── imgui-wgpu v0.24.0 (/Users/benediktmandelkow/gits/forks/imgui-wgpu-rs)
│               └── wgpu-core v0.20.0
│                   └── wgpu v0.20.0 (*)
├── num_enum_derive v0.7.2 (proc-macro)
│   └── num_enum v0.7.2
│       ├── android-activity v0.5.2
│       │   └── winit v0.29.15 (*)
│       └── ndk v0.8.0
│           ├── android-activity v0.5.2 (*)
│           └── winit v0.29.15 (*)
├── thiserror-impl v1.0.60 (proc-macro)
│   └── thiserror v1.0.60
│       ├── android-activity v0.5.2 (*)
│       ├── calloop v0.12.4
│       │   ├── calloop-wayland-source v0.2.0
│       │   │   └── smithay-client-toolkit v0.18.1
│       │   │       ├── sctk-adwaita v0.8.1 (*)
│       │   │       └── winit v0.29.15 (*)
│       │   ├── smithay-client-toolkit v0.18.1 (*)
│       │   └── winit v0.29.15 (*)
│       ├── gpu-allocator v0.25.0
│       │   └── wgpu-hal v0.20.0 (*)
│       ├── hassle-rs v0.11.0
│       │   └── wgpu-hal v0.20.0 (*)
│       ├── jni v0.21.1
│       │   └── android-activity v0.5.2 (*)
│       ├── naga v0.20.0
│       │   ├── wgpu-core v0.20.0 (*)
│       │   └── wgpu-hal v0.20.0 (*)
│       ├── ndk v0.8.0 (*)
│       ├── smithay-client-toolkit v0.18.1 (*)
│       ├── wgpu-core v0.20.0 (*)
│       └── wgpu-hal v0.20.0 (*)
├── wasm-bindgen-backend v0.2.92
│   └── wasm-bindgen-macro-support v0.2.92
│       └── wasm-bindgen-macro v0.2.92 (proc-macro)
│           └── wasm-bindgen v0.2.92
│               ├── glow v0.13.1
│               │   └── wgpu-hal v0.20.0 (*)
│               ├── js-sys v0.3.69
│               │   ├── glow v0.13.1 (*)
│               │   ├── wasm-bindgen-futures v0.4.42
│               │   │   ├── wgpu v0.20.0 (*)
│               │   │   └── winit v0.29.15 (*)
│               │   ├── web-sys v0.3.69
│               │   │   ├── glow v0.13.1 (*)
│               │   │   ├── wasm-bindgen-futures v0.4.42 (*)
│               │   │   ├── wgpu v0.20.0 (*)
│               │   │   ├── wgpu-core v0.20.0 (*)
│               │   │   ├── wgpu-hal v0.20.0 (*)
│               │   │   ├── wgpu-types v0.20.0
│               │   │   │   ├── wgpu v0.20.0 (*)
│               │   │   │   ├── wgpu-core v0.20.0 (*)
│               │   │   │   └── wgpu-hal v0.20.0 (*)
│               │   │   └── winit v0.29.15 (*)
│               │   ├── web-time v0.2.4
│               │   │   └── winit v0.29.15 (*)
│               │   ├── wgpu v0.20.0 (*)
│               │   ├── wgpu-hal v0.20.0 (*)
│               │   ├── wgpu-types v0.20.0 (*)
│               │   └── winit v0.29.15 (*)
│               ├── wasm-bindgen-futures v0.4.42 (*)
│               ├── web-sys v0.3.69 (*)
│               ├── web-time v0.2.4 (*)
│               ├── wgpu v0.20.0 (*)
│               ├── wgpu-hal v0.20.0 (*)
│               └── winit v0.29.15 (*)
├── wasm-bindgen-macro-support v0.2.92 (*)
└── zerocopy-derive v0.7.34 (proc-macro)
    └── zerocopy v0.7.34
        └── ahash v0.8.11
            ├── hashbrown v0.14.5
            │   └── gpu-descriptor v0.3.0
            │       └── wgpu-hal v0.20.0 (*)
            └── winit v0.29.15 (*)

both syn versions get pulled in by wgpu

@mkrasnitski
Copy link
Contributor

I would personally prefer that #107 is merged first and then this gets rebased on top of it. Not all of the ecosystem has updated to 0.20 yet (for example only the git branch of egui has). Additionally, that PR is relevant for parasyte/pixels#391, and having just this repo use wgpu 0.20 instead of 0.19 would cause some mild dependency hell for that project. Am I correct that other than the bump from wgpu being to 0.20 instead of 0.19, the two PRs are otherwise equivalent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants