-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matrixClient.http.authedRequest calls #27
base: main
Are you sure you want to change the base?
Conversation
With matrix-org/matrix-js-sdk#2719 the signature of `authedRequest` has changed. They now do not expect a callback as the first parameter anymore. All other parameters have just moved up by one.
I have tested this locally with the latest |
Thanks. Maybe we should also update the package json files to a version of matrix-js-sdk that you can confirm is working? I'm not actively working on matrix-crdt at this moment |
I went ahead and pinned matrix-js-sdk to said version, which I had successfully tested the library with. I also made some adjustments to the TypeScript annotations where the JS SDK has changed in the meantime... However, I wasn't able to fix all concerns. I guess
|
With matrix-org/matrix-js-sdk#2719 the signature of
authedRequest
has changed. They now do not expect a callback as the first parameter anymore.All other parameters have just moved up by one.