Update to Misskey v13, NodeJS 18.13.0, remove Yarn, add pnpm #145
Conversation
|
|
|
!testme |
|
Fingers crossed! |
|
|
|
!testme |
|
May the CI gods be with you! |
|
|
Is there any way to do that without relying on git to download the release ? Because if I understand correctly this won't allow us to set a fixed version (and sha256sum it properly) ? |
|
I'm waiting a reviewer to see if I'm on the good way 🤞 |
|
ping @YunoHost-Apps/apps-group then ? |
oufmilo
changed the title
|
!testme |
|
🌻 |
|
✌️ |
| # Download, check integrity, uncompress and patch the source from app.src | ||
| ynh_setup_source --dest_dir="$final_path" | ||
| # Note: We use git instead of ynh_setup_source, cause this repo use submodules | ||
| git clone https://github.com/misskey-dev/misskey.git "$final_path" --quiet |
There was a problem hiding this comment.
Can you elaborate on why you're switching to git clone x_x
This yield like a new shitload of issue and creates heterogenous practices instead of sticking to ynh_setup_source ...
There was a problem hiding this comment.
Because of this:
git submodule update --init should be added to fetch fluent-emojis and missky assets
Suggested by @Lastorder-DC.
I'm still wondering if there is another way around, because as you said this will create a lot of extra work.
There was a problem hiding this comment.
One way is fork misskey and instead of submodule, add all files to repo(like before)
Someone should maintain fork, but when updating testing branch maintainer can update fork and apply
There was a problem hiding this comment.
But those file aren't stored anywhere ? No way to just download them ?
There was a problem hiding this comment.
Or generated ?
I don't get it, those files are coming from somewhere, why can't we retrieve them ?
There was a problem hiding this comment.
It can be fetched from repo
https://github.com/misskey-dev/emojis/tree/cae981eb4c5189ea9ea3230e83b876a5068df7d1
https://github.com/misskey-dev/assets/tree/0179793ec891856d6f37a3be16ba4c22f67a81b5
so maybe, we can download zip instead and place to proper folder to remove git clone / submodule init stuff.(I'm not expert to git stuff so correct me If I'm wrong)
There was a problem hiding this comment.
Great ! Then we found another way, thanks :)
Now we just need to download those 2 folders https://github.com/misskey-dev/emojis/tree/cae981eb4c5189ea9ea3230e83b876a5068df7d1/dist & https://github.com/misskey-dev/assets/tree/0179793ec891856d6f37a3be16ba4c22f67a81b5/live2d/ai and place them where they are supposed to be - where is it ? 😅
@oufmilo do you think you could try to revert to the classic Yunohost install process and then download those files ?
There was a problem hiding this comment.
to misskey root folder
misskey-dev/emojis -> fluent-emojis
misskey-dev/assets-> misskey-assets
whole repo should be put there so there will be files like misskey-assets/live2d/ai/~~~
|
!testme |
|
🌻 |
|
Maybe the title has to be edited to state that this include v13 ? |
tituspijean
changed the title
|
!testme |
|
May the CI gods be with you! |
|
@oufmilo, cf. review above, what do you think about the proposal to switch back to zip files instead of git? The submodules could easily be updated if we switch to packaging v2. |
Update NodeJS 18.13.0 + Remove Yarn + Add pnpm
Problem
I can't upgrade from current version since i've changed the install script due to pnpm.
And it doesn't recognize git
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)