Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new filters - String case filters #245

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: Add new filters - String case filters #245

wants to merge 6 commits into from

Conversation

rafaelss95
Copy link

@rafaelss95 rafaelss95 commented Jan 29, 2017

@rafaelss95 rafaelss95 changed the title feat(underscore): Add new filter - 'UnderscoreFilter' feat: Add new filters - String case filters Jan 29, 2017
@rafaelss95
Copy link
Author

@a8m Will you merge this?

README.md Outdated
```html
<p>{{ 'a_simple_word' | camelize }}</p>
<p>{{ 'ANUPPERCASEDWORD' | camelize }}</p>
<p>{{ 'angular-js' | camelize: true }}</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also mention what happens to a sentence -> aSentence

README.md Outdated
###camelize

Converts a string to camelCase<br/>
usage: ```string | camelize: [upperFirst:boolean|optional]```<br/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The camelCase filter with upperFirst enabled is basically a PascalCase filter. Maybe it's better to split them up into two filters.

README.md Outdated
@@ -1216,6 +1216,23 @@ a_n_u_p_p_e_r_c_a_s_e_d_w_o_r_d
-->
```

###camelize

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not call it camelCase?

README.md Outdated

<!--
result:
aSimpleWord

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anuppercaseword is missing

@rafaelss95
Copy link
Author

@SteveVanOpstal, please check it now. I've made some changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants