-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new filters - String case filters #245
base: master
Are you sure you want to change the base?
Conversation
@a8m Will you merge this? |
README.md
Outdated
```html | ||
<p>{{ 'a_simple_word' | camelize }}</p> | ||
<p>{{ 'ANUPPERCASEDWORD' | camelize }}</p> | ||
<p>{{ 'angular-js' | camelize: true }}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also mention what happens to a sentence
-> aSentence
README.md
Outdated
###camelize | ||
|
||
Converts a string to camelCase<br/> | ||
usage: ```string | camelize: [upperFirst:boolean|optional]```<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The camelCase filter with upperFirst
enabled is basically a PascalCase filter. Maybe it's better to split them up into two filters.
README.md
Outdated
@@ -1216,6 +1216,23 @@ a_n_u_p_p_e_r_c_a_s_e_d_w_o_r_d | |||
--> | |||
``` | |||
|
|||
###camelize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not call it camelCase?
README.md
Outdated
|
||
<!-- | ||
result: | ||
aSimpleWord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anuppercaseword
is missing
@SteveVanOpstal, please check it now. I've made some changes. |
#244