Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement | Recommended Subscribers (FE) #255

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

malisettisamrat
Copy link
Contributor

@malisettisamrat malisettisamrat commented Jul 16, 2024

Recommended Subscribers on Users Home Page

Description

Added Recommended Subscribers on User Home Page to show the top followers in the Figuring Out.

Linked Issues

Type of Change

  • New feature (non-breaking change which adds functionality)

Changes

  • Added the list of recommended subscribers with follow/unfollow button on Home Page.
  • Created the new component to show the recommended subscribers.
  • Created a new skeleton for the recommended subscribers while loading the home page.

Screenshots/Recordings

https://www.loom.com/share/69ca121819bc492cbf08bf579824908c?sid=eadc6560-c128-435c-9e45-d2b4ffb33987

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there are no similar/duplicate pull requests regarding the same issue
  • My changes follow the project's coding guidelines and best practices
  • Code is formatted properly and lint check passes successfully
  • I have made corresponding changes to the documentation (if applicable)

Additional Notes

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medium-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 9:24pm

@malisettisamrat malisettisamrat changed the title Feature: Recommended Subscribers Feature: Recommended Subscribers (FE) | User Home Page Jul 16, 2024
@aadeshkulkarni
Copy link
Owner

The UI looks cluttered.

  • you can add a separator between blogs and subscribers ?
  • Or, you can a add border to the subscribers containers.

Please refer Medium.com's home page for reference.

@aadeshkulkarni aadeshkulkarni changed the title Feature: Recommended Subscribers (FE) | User Home Page Enhancement | Recommended Subscribers (FE) Jul 21, 2024
@aadeshkulkarni
Copy link
Owner

npm build fails with the following error:

Screenshot 2024-07-21 at 9 20 28 PM

Please fix

@malisettisamrat
Copy link
Contributor Author

@aadeshkulkarni, I have modified the changes that are requested. Please review and merge my PR. Thanks!

disabled={loadingSubscriber}
onClick={toggleSubscription}
>
{loadingSubscriber && <Spinner className="w-4 h-4" />}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loader is perpetually loading here

Screen.Recording.2024-09-04.at.12.35.05.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants