Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue Bug | Remove the animate pulse on Blogs skeleton #266 #268

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SaiManojCheruvu
Copy link

Pull Request Title

Fixed the issue Bug | Remove the animate pulse on Blogs skeleton #266

Description

A pulse sort of load at UserHomeTab, BlogsList
Resolves #266

Changes

  • Remove class name causing the pulse

  • [y] I have performed a self-review of my code

  • [y] I assure there are no similar/duplicate pull requests regarding the same issue

  • [y] My changes follow the project's coding guidelines and best practices

  • [y] Code is formatted properly and lint check passes successfully

  • [y] I have made corresponding changes to the documentation (if applicable)

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medium-app ❌ Failed (Inspect) Sep 4, 2024 11:51am

@SaiManojCheruvu
Copy link
Author

Fixed the issue Bug | Remove the animate pulse on Blogs skeleton #266

Copy link
Owner

@aadeshkulkarni aadeshkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in BlogsSkeleton.tsx looks good. But, there are unnecessary packages that are added in package.json and package-lock.json, which are not needed as part of this issue.
Request you to remove them so that the PR can be moved forward please.

@SaiManojCheruvu
Copy link
Author

Hello @aadeshkulkarni, Just fixed the package.json issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug | Remove the animate pulse on Blogs skeleton
2 participants