Use QR for Rational as well and tighten LINPACK pivot tolerance a bit.

aadler · Aug 20, 2023 · 4fcefe3 · 4fcefe3
1 parent ab942a0
commit 4fcefe3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R/RemezPolynomial.R b/R/RemezPolynomial.R
@@ -14,7 +14,7 @@ polyMat <- function(x, y, relErr) {
 # Function to calculate coefficients given matrix and known values
 polyCoeffs <- function(x, fn, relErr) {
   y <- callFun(fn, x)
-  PP <- qr.solve(polyMat(x, y, relErr), y)
+  PP <- qr.solve(polyMat(x, y, relErr), y, tol = 1e-12)
   list(a = PP[-length(PP)], E = PP[length(PP)])
 }
 

diff --git a/R/RemezRational.R b/R/RemezRational.R
@@ -17,7 +17,7 @@ ratMat <- function(x, E, y, nD, dD, relErr) {
 # Function to calculate coefficients given matrix and known values
 ratCoeffs <- function(x, E, fn, nD, dD, relErr) {
   y <- callFun(fn, x)
-  P <- solve(ratMat(x, E, y, nD, dD, relErr), y)
+  P <- qr.solve(ratMat(x, E, y, nD, dD, relErr), y, tol = 1e-12)
   list(a = P[seq_len(nD + 1L)],            # Works even if nD = 0
        b = c(1, P[seq_len(dD) + nD + 1L]), # Works even if dD = 0
        E = P[length(P)])