Merge pull request #209 from ably/MAW-320

Update Footer For Press Center
ably · Sep 5, 2022 · 1dff555 · 1dff555
2 parents aa1ab13 + f81a5c6
commit 1dff555
Show file tree

Hide file tree

Showing 10 changed files with 22 additions and 40 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ably-ui (8.2.1.dev.611f3bd)
+    ably-ui (8.2.1.dev.db8f789)
       view_component (>= 2.33, < 2.50)
 
 GEM

diff --git a/cypress/integration/core/footer/__snapshots__/snapshots.js.snap b/cypress/integration/core/footer/__snapshots__/snapshots.js.snap
@@ -120,16 +120,12 @@ exports[`Footer Snapshot Test > react > test case common to both #0`] = `
       <h2 class="ui-footer-col-title">Developers</h2>
       <ul>
         <li class="p-menu-row-snug">
-          <a
-            href="/docs/quick-start-guide"
-            class="ui-footer-menu-row-link"
+          <a href="/docs/quick-start-guide" class="ui-footer-menu-row-link"
             >Start in 5 minutes</a
           >
         </li>
         <li class="p-menu-row-snug">
-          <a href="/docs/" class="ui-footer-menu-row-link"
-            >Documentation</a
-          >
+          <a href="/docs/" class="ui-footer-menu-row-link">Documentation</a>
         </li>
         <li class="p-menu-row-snug">
           <a href="/tutorials" class="ui-footer-menu-row-link">Tutorials</a>
@@ -218,11 +214,7 @@ exports[`Footer Snapshot Test > react > test case common to both #0`] = `
           >
         </li>
         <li class="p-menu-row-snug">
-          <a
-            href="https://www.notion.so/ably/Ably-Press-Center-551152f5be724d4495a7c2e29d9f51c7"
-            rel="noopener noreferrer"
-            target="_blank"
-            class="ui-footer-menu-row-link"
+          <a href="/press-center" class="ui-footer-menu-row-link"
             >Press &amp; Media</a
           >
         </li>
@@ -428,16 +420,12 @@ exports[`Footer Snapshot Test > view component > test case common to both #0`] =
       <h2 class="ui-footer-col-title">Developers</h2>
       <ul>
         <li class="p-menu-row-snug">
-          <a
-            class="ui-footer-menu-row-link"
-            href="/docs/quick-start-guide"
+          <a class="ui-footer-menu-row-link" href="/docs/quick-start-guide"
             >Start in 5 minutes</a
           >
         </li>
         <li class="p-menu-row-snug">
-          <a class="ui-footer-menu-row-link" href="/docs"
-            >Documentation</a
-          >
+          <a class="ui-footer-menu-row-link" href="/docs">Documentation</a>
         </li>
         <li class="p-menu-row-snug">
           <a class="ui-footer-menu-row-link" href="/tutorials">Tutorials</a>
@@ -529,11 +517,7 @@ exports[`Footer Snapshot Test > view component > test case common to both #0`] =
           >
         </li>
         <li class="p-menu-row-snug">
-          <a
-            href="https://www.notion.so/ably/Ably-Press-Center-551152f5be724d4495a7c2e29d9f51c7"
-            target="_blank"
-            rel="noopener"
-            class="ui-footer-menu-row-link"
+          <a class="ui-footer-menu-row-link" href="/press-center"
             >Press &amp; Media</a
           >
         </li>

diff --git a/lib/ably_ui/version.rb b/lib/ably_ui/version.rb
@@ -1,3 +1,3 @@
 module AblyUi
-  VERSION = '8.2.1.dev.611f3bd'
+  VERSION = '8.2.1.dev.db8f789'
 end
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ably/ui",
-  "version": "8.2.1-dev.611f3bd",
+  "version": "8.2.1-dev.db8f789",
   "description": "Home of the Ably design system library ([design.ably.com](https://design.ably.com)). It provides a showcase, development/test environment and a publishing pipeline for different distributables.",
   "repository": {
     "type": "git",

diff --git a/preview/Gemfile b/preview/Gemfile
@@ -36,7 +36,7 @@ gem 'view_component', '~> 2.33.0', require: 'view_component/engine'
 
 gem 'responders'
 
-gem 'ably-ui', '8.2.1.dev.611f3bd', require: 'ably_ui'
+gem 'ably-ui', '8.2.1.dev.db8f789', require: 'ably_ui'
 
 # https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias
 gem 'psych', '< 4'

diff --git a/preview/Gemfile.lock b/preview/Gemfile.lock
@@ -1,7 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    ably-ui (8.2.1.dev.611f3bd)
+    ably-ui (8.2.1.dev.db8f789)
       view_component (>= 2.33, < 2.50)
     actioncable (6.0.5.1)
       actionpack (= 6.0.5.1)
@@ -89,6 +89,8 @@ GEM
     minitest (5.16.2)
     msgpack (1.5.3)
     nio4r (2.5.8)
+    nokogiri (1.13.7-arm64-darwin)
+      racc (~> 1.4)
     nokogiri (1.13.7-x86_64-darwin)
       racc (~> 1.4)
     nokogiri (1.13.7-x86_64-linux)
@@ -167,11 +169,12 @@ GEM
     zeitwerk (2.6.0)
 
 PLATFORMS
+  arm64-darwin-21
   x86_64-darwin-21
   x86_64-linux
 
 DEPENDENCIES
-  ably-ui (= 8.2.1.dev.611f3bd)
+  ably-ui (= 8.2.1.dev.db8f789)
   bootsnap (>= 1.4.2)
   byebug
   dotenv-rails

diff --git a/preview/package.json b/preview/package.json
@@ -2,7 +2,7 @@
   "name": "preview",
   "private": true,
   "dependencies": {
-    "@ably/ui": "8.2.1-dev.611f3bd",
+    "@ably/ui": "8.2.1-dev.db8f789",
     "@babel/preset-react": "^7.12.5",
     "@rails/ujs": "^6.0.0",
     "@rails/webpacker": "4.3.0",

diff --git a/preview/yarn.lock b/preview/yarn.lock
@@ -2,10 +2,10 @@
 # yarn lockfile v1
 
 
-"@ably/[email protected].611f3bd":
-  version "8.2.1-dev.611f3bd"
-  resolved "https://registry.yarnpkg.com/@ably/ui/-/ui-8.2.1-dev.611f3bd.tgz#35761259b8452465297f681609f8d95f80a068af"
-  integrity sha512-uFTmU4VMvGg7L1l+Ox6Yq6k8mPlprgfDCV720GVpxldGzdXEa4s62ABHcdf7lkk286pwvZduaaVI/pg9cr9t1A==
+"@ably/[email protected].db8f789":
+  version "8.2.1-dev.db8f789"
+  resolved "https://registry.yarnpkg.com/@ably/ui/-/ui-8.2.1-dev.db8f789.tgz#5bc377811505f5b6f946ce751fe35683cd12a966"
+  integrity sha512-xo+Y686LMxGCU7fsHQTfpK/8qXW8ih0tj34DKx8F8asYfsV6pQGR351xbUT07vEuuvxDWS6ba8BvSGXrn5J4Zw==
   dependencies:
     addsearch-js-client "^0.7.0"
     array-flat-polyfill "^1.0.1"

diff --git a/src/core/Footer/component.html.erb b/src/core/Footer/component.html.erb
@@ -141,7 +141,7 @@
           <%= link_to 'Open protocol policy', abs_url("/open-policy"), class: "ui-footer-menu-row-link" %>
         </li>
         <li class="p-menu-row-snug">
-          <a href="https://www.notion.so/ably/Ably-Press-Center-551152f5be724d4495a7c2e29d9f51c7" target="_blank" rel="noopener" class="ui-footer-menu-row-link">Press & Media</a>
+         <%= link_to 'Press & Media', abs_url("/press-center"), class: "ui-footer-menu-row-link" %>
         </li>
         <li class="p-menu-row-snug">
           <%= link_to 'Contact us', abs_url("/contact"), class: "ui-footer-menu-row-link" %>

diff --git a/src/core/Footer/component.jsx b/src/core/Footer/component.jsx
@@ -219,12 +219,7 @@ export default function Footer({ paths, urlBase }) {
               </a>
             </li>
             <li className="p-menu-row-snug">
-              <a
-                href="https://www.notion.so/ably/Ably-Press-Center-551152f5be724d4495a7c2e29d9f51c7"
-                rel="noopener noreferrer"
-                target="_blank"
-                className="ui-footer-menu-row-link"
-              >
+              <a href={absUrl("/press-center")} className="ui-footer-menu-row-link">
                 Press & Media
               </a>
             </li>