Skip to content

Commit

Permalink
resolves #296 use Ubuntu 22.04 by default (#334)
Browse files Browse the repository at this point in the history
  • Loading branch information
slonopotamus authored Oct 17, 2023
1 parent 4f22719 commit edb8be4
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions docs/advanced-build-options.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,9 @@ ue4-docker build RELEASE --cuda

[source,shell]
----
# Uses the CUDA 10.0 base image
ue4-docker build RELEASE --cuda=10.0
# Uses the CUDA 12.2.0 base image
ue4-docker build RELEASE --cuda=12.2.0
{% endhighlight %}
----

For a list of supported CUDA versions, see the list of Ubuntu 18.04 image tags for the https://hub.docker.com/r/nvidia/cuda/[nvidia/cuda] base image.
For a list of supported CUDA versions, see the list of Ubuntu 22.04 image tags for the https://hub.docker.com/r/nvidia/cuda/[nvidia/cuda] base image.
2 changes: 1 addition & 1 deletion docs/ue4-docker-build.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ See the xref:available-container-images.adoc[List of available container images]

*-basetag* _basetag_::
Operating system base image tag to use.
For Linux this is the version of Ubuntu (default is ubuntu18.04).
For Linux this is the version of Ubuntu (default is ubuntu22.04).
For Windows this is the Windows Server Core base image tag (default is the host OS version)

*-branch* _branch_::
Expand Down
6 changes: 3 additions & 3 deletions src/ue4docker/infrastructure/BuildConfiguration.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
}

# The default ubuntu base to use
DEFAULT_LINUX_VERSION = "ubuntu18.04"
DEFAULT_LINUX_VERSION = "ubuntu22.04"

# The default CUDA version to use when `--cuda` is specified without a value
DEFAULT_CUDA_VERSION = "11.4"
DEFAULT_CUDA_VERSION = "12.2.0"

# The default memory limit (in GB) under Windows
DEFAULT_MEMORY_LIMIT = 10.0
Expand Down Expand Up @@ -206,7 +206,7 @@ def addArguments(parser):
parser.add_argument(
"-basetag",
default=None if platform.system() == "Windows" else DEFAULT_LINUX_VERSION,
help="Operating system base image tag to use. For Linux this is the version of Ubuntu (default is ubuntu18.04). "
help="Operating system base image tag to use. For Linux this is the version of Ubuntu (default is ubuntu22.04). "
"For Windows this is the Windows Server Core base image tag (default is the host OS version)",
)
parser.add_argument(
Expand Down

0 comments on commit edb8be4

Please sign in to comment.