Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support og:image and twitter:image in page metadata #591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jckautzmann
Copy link

  • if available in the html, keep og:image and twitter:image as page metadata of the markdown document

Fixes #590

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

- if available in the html, keep og:image and twitter:image as page metadata of the markdown document
@jckautzmann
Copy link
Author

@tripodsan Could you please have a look at the PR? Thx.

Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's also ask @mhaack

Copy link
Collaborator

@buuhuu buuhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@mhaack mhaack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jckautzmann
Copy link
Author

Thx all for reviewing this PR. @tripodsan Could you please merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support og:image and twitter:image in page metadata
4 participants