feat: add TableView codemods #7117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
force-pushed
the
table-codemods
branch
from
82cbe8f
to
af847b4
Compare
|
gonna wait until after release for this one so we can test in more apps |
devongovett
reviewed
Oct 10, 2024
| <TableHeader> | ||
| <Column key="test">Test</Column> | ||
| <Column title="Blah"> | ||
| <Column title="Group 1"> |
There was a problem hiding this comment.
I think RAC/S2 doesn't support nested columns yet.
| // Ensure we're not replacing the parameter declaration | ||
| innerPath.node !== params[0] | ||
| ) { | ||
| // Replace with 'column.id' |
There was a problem hiding this comment.
I guess this is sort of an assumption that columns have an id property? They may not, it could be key or something computed. Probably won't be able to be 100% accurate here. I guess if we wanted to get fancy we could try to look at the id (previously key) prop of the Column component? e.g. <Column key={column.name}> and then use column.name here too.
| /** | ||
| * Updates the key prop to id. Keeps the key prop if it's used in an array.map function. | ||
| */ | ||
| function updateKeyToId( |
There was a problem hiding this comment.
Did we not already have something like this for other collection components like Item?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyto beidcolumnsprop fromTableHeaderto toRowRowrender function to pass column object, not just key✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: