-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: SelectBox #7297
Open
ktabors
wants to merge
9
commits into
main
Choose a base branch
from
selectboxgroup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: SelectBox #7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… styles from the figma docs
This is a branch of a branch. Creating a PR from original branch. |
Creating a new PR off of Dan's PR. |
## API Changes
react-aria-components/react-aria-components:ListBoxSection-ListBoxSection <T extends {}> {
- aria-label?: string
- children?: ReactNode | ({}) => ReactElement
- className?: string
- dependencies?: Array<any>
- id?: Key
- items?: Iterable<{}>
- style?: CSSProperties
- value?: {}
-} /react-aria-components:MenuSection-MenuSection <T extends {}> {
- aria-label?: string
- children?: ReactNode | ({}) => ReactElement
- className?: string
- defaultSelectedKeys?: 'all' | Iterable<Key>
- dependencies?: Array<any>
- disabledKeys?: Iterable<Key>
- disallowEmptySelection?: boolean
- id?: Key
- items?: Iterable<{}>
- onSelectionChange?: (Selection) => void
- selectedKeys?: 'all' | Iterable<Key>
- selectionMode?: SelectionMode
- style?: CSSProperties
- value?: {}
-} /react-aria-components:ListBoxSectionProps-ListBoxSectionProps <T> {
- aria-label?: string
- children?: ReactNode | (T) => ReactElement
- className?: string
- dependencies?: Array<any>
- id?: Key
- items?: Iterable<T>
- style?: CSSProperties
- value?: T
-} /react-aria-components:MenuSectionProps-MenuSectionProps <T> {
- aria-label?: string
- children?: ReactNode | (T) => ReactElement
- className?: string
- defaultSelectedKeys?: 'all' | Iterable<Key>
- dependencies?: Array<any>
- disabledKeys?: Iterable<Key>
- disallowEmptySelection?: boolean
- id?: Key
- items?: Iterable<T>
- onSelectionChange?: (Selection) => void
- selectedKeys?: 'all' | Iterable<Key>
- selectionMode?: SelectionMode
- style?: CSSProperties
- value?: T
-} @react-aria/menu/@react-aria/menu:AriaMenuItemProps AriaMenuItemProps {
aria-controls?: string
aria-expanded?: boolean | 'true' | 'false'
aria-haspopup?: 'menu' | 'dialog'
aria-label?: string
closeOnSelect?: boolean = true
id?: string
isVirtualized?: boolean
key?: Key
onBlur?: (FocusEvent<Target>) => void
onFocus?: (FocusEvent<Target>) => void
onFocusChange?: (boolean) => void
onHoverChange?: (boolean) => void
onHoverEnd?: (HoverEvent) => void
onHoverStart?: (HoverEvent) => void
onKeyDown?: (KeyboardEvent) => void
onKeyUp?: (KeyboardEvent) => void
onPress?: (PressEvent) => void
onPressChange?: (boolean) => void
onPressEnd?: (PressEvent) => void
onPressStart?: (PressEvent) => void
onPressUp?: (PressEvent) => void
- selectionManager?: SelectionManager
} @react-spectrum/s2/@react-spectrum/s2:MenuSection MenuSection <T extends {}> {
aria-label?: string
children?: ReactNode | ({}) => ReactElement
className?: string
- defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: Array<any>
- disabledKeys?: Iterable<Key>
- disallowEmptySelection?: boolean
id?: Key
items?: Iterable<{}>
- onSelectionChange?: (Selection) => void
- selectedKeys?: 'all' | Iterable<Key>
- selectionMode?: SelectionMode
style?: CSSProperties
value?: {}
} /@react-spectrum/s2:MenuSectionProps MenuSectionProps <T extends {}> {
aria-label?: string
children?: ReactNode | ({}) => ReactElement
className?: string
- defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: Array<any>
- disabledKeys?: Iterable<Key>
- disallowEmptySelection?: boolean
id?: Key
items?: Iterable<{}>
- onSelectionChange?: (Selection) => void
- selectedKeys?: 'all' | Iterable<Key>
- selectionMode?: SelectionMode
style?: CSSProperties
value?: {}
} /@react-spectrum/s2:SelectBox+SelectBox {
+ UNSAFE_className?: string
+ UNSAFE_style?: CSSProperties
+ children: ReactNode | (SelectBoxProps) => ReactNode
+ download?: boolean | string
+ href?: Href
+ hrefLang?: string
+ id?: Key
+ isDisabled?: boolean
+ onAction?: () => void
+ ping?: string
+ referrerPolicy?: HTMLAttributeReferrerPolicy
+ rel?: string
+ routerOptions?: RouterOptions
+ styles?: StylesProp
+ target?: HTMLAttributeAnchorTarget
+ textValue?: string
+ value: string
+} /@react-spectrum/s2:SelectBoxGroup+SelectBoxGroup <T extends {}> {
+ UNSAFE_className?: string
+ UNSAFE_style?: CSSProperties
+ aria-describedby?: string
+ aria-details?: string
+ aria-label?: string
+ aria-labelledby?: string
+ children?: ReactNode
+ defaultSelectedKeys?: 'all' | Iterable<Key>
+ defaultValue?: Array<string>
+ dependencies?: Array<any>
+ disabledBehavior?: DisabledBehavior
+ disabledKeys?: Iterable<Key>
+ disallowEmptySelection?: boolean
+ id?: string
+ isDisabled?: boolean
+ isRequired?: boolean
+ items?: Iterable<T>
+ label?: ReactNode
+ onAction?: (Key) => void
+ onChange?: (Array<string>) => void
+ onScroll?: (UIEvent<Element>) => void
+ orientation?: Orientation
+ renderEmptyState?: (GridListRenderProps) => ReactNode
+ selectedKeys?: 'all' | Iterable<Key>
+ selectionMode?: SelectionMode
+ size?: 'XS' | 'S' | 'M' | 'L' | 'XL'
+ slot?: string | null
+ value?: Array<string>
+} @react-stately/selection/@react-stately/selection:SelectionManager SelectionManager {
canSelectItem: (Key) => void
childFocusStrategy: FocusStrategy
clearSelection: () => void
- collection: Collection<Node<unknown>>
constructor: (Collection<Node<unknown>>, MultipleSelectionState, SelectionManagerOptions) => void
disabledBehavior: DisabledBehavior
disabledKeys: Set<Key>
disallowEmptySelection: boolean
firstSelectedKey: Key | null
focusedKey: Key
getItemProps: (Key) => void
isDisabled: (Key) => void
isEmpty: boolean
isFocused: boolean
isLink: (Key) => void
isSelectAll: boolean
isSelected: (Key) => void
isSelectionEqual: (Set<Key>) => void
lastSelectedKey: Key | null
rawSelection: Selection
replaceSelection: (Key) => void
select: (Key, PressEvent | LongPressEvent | PointerEvent) => void
selectAll: () => void
selectedKeys: Set<Key>
selectionBehavior: SelectionBehavior
selectionMode: SelectionMode
setFocused: (boolean) => void
setFocusedKey: (Key | null, FocusStrategy) => void
setSelectedKeys: (Iterable<Key>) => void
setSelectionBehavior: (SelectionBehavior) => void
toggleSelectAll: () => void
toggleSelection: (Key) => void
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/orgs/adobe/projects/19/views/4?pane=issue&itemId=66073041
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP