Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Imizga/sp card img #4938

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

mizgaionutalexandru
Copy link
Contributor

Description

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

github-actions bot commented Nov 18, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.98 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 250.849 kB 236.269 kB 🏆 236.81 kB
Scripts 60.702 kB 53.967 kB 🏆 54.294 kB
Stylesheet 53.845 kB 47.825 kB 🏆 48.027 kB
Document 6.223 kB 5.467 kB 🏆 5.469 kB
Font 127.114 kB 126.598 kB 🏆 126.634 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

coveralls commented Nov 18, 2024

Pull Request Test Coverage Report for Build 11895624206

Details

  • 39 of 39 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 98.204%

Totals Coverage Status
Change from base Build 11859867829: 0.009%
Covered Lines: 32306
Relevant Lines: 32721

💛 - Coveralls

Copy link

github-actions bot commented Nov 18, 2024

Tachometer results

Chrome

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 781 kB 37.17ms - 39.34ms - faster ✔
3% - 9%
1.04ms - 3.67ms
branch 756 kB 39.87ms - 41.35ms slower ❌
3% - 10%
1.04ms - 3.67ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 716 kB 43.77ms - 44.62ms - slower ❌
1% - 3%
0.45ms - 1.48ms
branch 672 kB 42.95ms - 43.52ms faster ✔
1% - 3%
0.45ms - 1.48ms
-
Firefox

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 781 kB 78.61ms - 85.83ms - faster ✔
1% - 12%
0.35ms - 10.37ms
branch 756 kB 84.10ms - 91.06ms slower ❌
0% - 13%
0.35ms - 10.37ms
-

grid permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 716 kB 88.87ms - 94.97ms - unsure 🔍
-1% - +10%
-0.54ms - +8.26ms
branch 672 kB 84.88ms - 91.24ms unsure 🔍
-9% - +0%
-8.26ms - +0.54ms
-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants