Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Added fresh cmd-line tools and Android 12 #485

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dbudim
Copy link

@dbudim dbudim commented Dec 22, 2021

  • ANDROID_HOME replaced by ANDROID_SDK_ROOT
  • Changed path to sdk due to package refactoring of fresh cmd-line tools
  • up appium default version

built image with 12 android can find here

@dbudim dbudim changed the title Android 12 [Android] Added fresh comandline tools and Android 12 Dec 22, 2021
@dbudim dbudim changed the title [Android] Added fresh comandline tools and Android 12 [Android] Added fresh cmd-line tools and Android 12 Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #485 (ac946d6) into master (e67da1c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #485   +/-   ##
======================================
  Coverage    6.24%   6.24%           
======================================
  Files           7       7           
  Lines         785     785           
======================================
  Hits           49      49           
  Misses        729     729           
  Partials        7       7           
Flag Coverage Δ
go 6.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82c6d47...ac946d6. Read the comment docs.

) && \
ldconfig && \
( \
resize2fs /root/.android/avd/$AVD_NAME.avd/userdata.img "$USERDATA_SIZE"M || \
/opt/android-sdk-linux/emulator/qemu-img resize -f raw /root/.android/avd/$AVD_NAME.avd/userdata.img "$USERDATA_SIZE"M \
/opt/emulator/qemu-img resize -f raw /root/.android/avd/$AVD_NAME.avd/userdata.img "$USERDATA_SIZE"M \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't get where emulator directory comes from.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't get where emulator directory comes from.

During building process i saw interesting logs:
=> => # Warning: Package "com.android.repository.impl.generated.v2.RemotePackage@863816ad" (emulator) should be installed in
=> => # "/opt/emulator" but
=> => # it already exists.
=> => # Installing in "/opt/emulator-2" instead.

And turned out that when you fetch system image e.g. sdkmanager "system-images;android-31;default;x86_64"

it automatically fetch emulator directory too.
So i decided remove fetch emulator directly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these changes work for older Android versions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting question)
What boundaries of supported versions need to test?
Because i'm not sure about backward compatibility of new SDK)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbudim at least Android 6.0+.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i'll check 6th and back with result)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've checked 6,7 versions - doesn't work, seems problem in vulkan drivers.
Need some free time for investigate this. Will do a bit later)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbudim sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants