Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adds typing to the decorators #838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fabiob
Copy link

@fabiob fabiob commented Apr 3, 2024

What do these changes do?

They add strong typing to aiocache decorator syntax.

Are there changes in behavior for the user?

Somewhat, as their IDEs will start to hint at the expected usage of the decorators.

Related issue number

It is related to #512 and #791

Checklist

  • I think the code is well written (still a WIP though)
  • Unit tests for the changes exist (would love to get some guidance on that)
  • Documentation reflects the changes (I'm not sure it is needed)

@Dreamsorcerer
Copy link
Member

Any typing improvements will need to wait until other tasks on the v1 milestone are complete. At the very least, we need mypy running, but that's currently blocked by 3 tasks preceding it: https://github.com/aio-libs/aiocache/milestone/8
(I ordered the tasks in the milestone so, for the most part, they need to be completed in that order to avoid issues).

@guybortnikov
Copy link

@fabiob @Dreamsorcerer any update on this PR? It will help for any project that uses type checking

@Dreamsorcerer
Copy link
Member

See the previous comment: #838 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants