Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved text shaping #3106

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Improved text shaping #3106

wants to merge 52 commits into from

Commits on May 14, 2024

  1. Test

    @Rusino
    Rusino committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d11062c View commit details
    Browse the repository at this point in the history

  2. Adding the js shaper api

    @Rusino
    Rusino committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2945535 View commit details
    Browse the repository at this point in the history

  3. Add minimal text demo

    @fmalita
    fmalita committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a5032fc View commit details
    Browse the repository at this point in the history

  4. Latest verstion, visual tests 

    This is BEFORE we discussed it with Florin and
found lots of improvements to make
    @Rusino
    Rusino committed May 14, 2024
    Configuration menu
    Copy the full SHA
    18877ba View commit details
    Browse the repository at this point in the history

  5. Fixing few bugs

    @Rusino
    Rusino committed May 14, 2024
    Configuration menu
    Copy the full SHA
    113d6d1 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Text direction bug fixed

    @Rusino
    Rusino committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2c2a285 View commit details
    Browse the repository at this point in the history

  2. Some asserts on testing

    @Rusino
    Rusino committed May 15, 2024
    Configuration menu
    Copy the full SHA
    68d13d7 View commit details
    Browse the repository at this point in the history

  3. (Not working) substutute lottie shaper

    @Rusino
    Rusino committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e9aa6a2 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. (Still not working) lottie -> skia shaper

    @Rusino
    Rusino committed May 16, 2024
    Configuration menu
    Copy the full SHA
    dbf00bb View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Improve developer experinece 

    * Create npm script to run demo server
* Add config and npm script for doing a lighter dev build
    @b-wils
    b-wils committed May 17, 2024
    Configuration menu
    Copy the full SHA
    313381e View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Something is showing on the screen 

    One line text is not perfect
Multiline text is now showing
(Work in progress)
    @Rusino
    Rusino committed May 20, 2024
    Configuration menu
    Copy the full SHA
    3cb5ab8 View commit details
    Browse the repository at this point in the history

  2. Fixed multiline text

    @Rusino
    Rusino committed May 20, 2024
    Configuration menu
    Copy the full SHA
    b911732 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Use local font for the text sample

    @fmalita
    fmalita committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5a98844 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. More text samples

    @fmalita
    fmalita committed May 29, 2024
    Configuration menu
    Copy the full SHA
    ef0e03b View commit details
    Browse the repository at this point in the history

  2. Multiline text sort of working

    @Rusino
    Rusino committed May 29, 2024
    Configuration menu
    Copy the full SHA
    915ae16 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Removing all extra code that is not needed anymore. 

    Also fixed the line height issue.
    @Rusino
    Rusino committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a49e90e View commit details
    Browse the repository at this point in the history

  2. RTL & BIDI work

    @Rusino
    Rusino committed May 31, 2024
    Configuration menu
    Copy the full SHA
    84939b3 View commit details
    Browse the repository at this point in the history

  3. Shaper select

    @fmalita
    fmalita committed May 31, 2024
    Configuration menu
    Copy the full SHA
    94ef6f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Added zalgo text as an example

    @Rusino
    Rusino committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    70efdc8 View commit details
    Browse the repository at this point in the history

  2. Use Arial for zalgo sample

    @fmalita
    fmalita committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9da36a5 View commit details
    Browse the repository at this point in the history

  3. Restoring transformation

    @Rusino
    Rusino committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b8bad04 View commit details
    Browse the repository at this point in the history

  4. Removed debugging print; fixed line height

    @Rusino
    Rusino committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9843357 View commit details
    Browse the repository at this point in the history

  5. Adding banner.json

    @Rusino
    Rusino committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    42fb1f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Fixed the wrong offset in animation 

    (actually, in paths)
    @Rusino
    Rusino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6a9d202 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. More animated samples

    @fmalita
    fmalita committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0cbaa5f View commit details
    Browse the repository at this point in the history

  2. More animated samples

    @fmalita
    fmalita committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    50d15dd View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Minor sample tweaks

    @fmalita
    fmalita committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    2c2fa8d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Small bugs in the shaper

    @Rusino
    Rusino committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f6767f6 View commit details
    Browse the repository at this point in the history

  2. Dealt with   in the text

    @Rusino
    Rusino committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    97b9e9a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Word-based animation samples

    @fmalita
    fmalita committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ff30307 View commit details
    Browse the repository at this point in the history

  2. Fixing word animation

    @Rusino
    Rusino committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    008c050 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Fixing animation for the text on path

    @Rusino
    Rusino committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    10b5ed6 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Fixed an arabic bug

    @Rusino
    Rusino committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    badef0a View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. This is the incomplete change for arabic text 

    Currently, the arabic text shows in the wrong order.
However, this version turns off arabic ligatures and
this is the right approach.
We need to add another shaping pass to establish the
correct text directions.
    @Rusino
    Rusino committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    bdc8209 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Revert "This is the incomplete change for arabic text" 

    (stashed in the 'arabic-wip' branch)

This reverts commit bdc8209.
    @fmalita
    fmalita committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d3948d7 View commit details
    Browse the repository at this point in the history

  2. Add rendererSettings.useSkriptShaping flag to control shaping 

    Also update the text sample page to show side-by-side examples.
    @fmalita
    fmalita committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    4479ff3 View commit details
    Browse the repository at this point in the history

  3. Use \r for new lines. Support multiple \r

    @Rusino
    Rusino committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a5d752b View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Fixinig multiple \r 

    Needs refactoring right away - the code is not clean
    @Rusino
    Rusino committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6a57ebb View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Temp state, the demo works

    @Rusino
    Rusino committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c9c61b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Multiple \r seems to be fixed (finally!)

    @Rusino
    Rusino committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d99cf35 View commit details
    Browse the repository at this point in the history

  2. Adding tests from scottie resources 

    Opens with 0.0.0.0:8000/demo/text/skottie/
First test is a single Skript test for debugging
The rest comes from the skottie resources
    @Rusino
    Rusino committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    19ffb2e View commit details
    Browse the repository at this point in the history

  3. Fixed airbnb#34, airbnb#35, airbnb#46, airbnb#48, airbnb#49

    @Rusino
    Rusino committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ad0f8fd View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Fixed the line length situaion. 

    Leading/trailing spaces are still a problem.
Tests airbnb#45 & airbnb#50.
4 tests fail on caught exception outside of the shaper: airbnb#13, airbnb#22. airbnb#36, airbnb#44.
    @Rusino
    Rusino committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0ffdfc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Add sample Skottie player

    @fmalita
    fmalita committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    683073d View commit details
    Browse the repository at this point in the history

  2. Fixed trailing spaces & chardata sizes

    @Rusino
    Rusino committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    f74723d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into HEAD

    @Rusino
    Rusino committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    7d5146d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Rename elements/browserElements/api.js -> utils/text/SkriptShaper.js

    @fmalita
    fmalita committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    02178a7 View commit details
    Browse the repository at this point in the history

  2. Rename demo/text -> demo/text-shaper

    @fmalita
    fmalita committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bbd3f68 View commit details
    Browse the repository at this point in the history

  3. Remove extra skottie demo

    @fmalita
    fmalita committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    490260c View commit details
    Browse the repository at this point in the history

  4. Cleanup

    @fmalita
    fmalita committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8c71255 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Fixes for Hernan's review

    @Rusino
    Rusino committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    44ef95f View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Optional logging

    @fmalita
    fmalita committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8b667fa View commit details
    Browse the repository at this point in the history