-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for submodule fetch #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed response. In addition to the comment about splitting the operations, I'd also be looking to have tests of this functionality similar to the others and documentation in the docs
folder.
repo.jgit.submoduleInit().call() | ||
repo.jgit.submoduleUpdate().call() | ||
repo.jgit.submoduleSync().call() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With other operations, we've stuck to a single JGit command per operation. Seems like this should be split out into 3 operations and a submodule service to provide fluent access to them.
In line with the current state of the project (see the readme), I won't be adding new functionality to grgit. |
Background
Right now there is no way to update submodules in grgit. This is very handy when using submodules as developers often forget to clone submodules
What changes
UpdateSubmodulesOp