Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflow for automated testing #2

Open
wants to merge 44 commits into
base: plugin-framework-mux
Choose a base branch
from

Conversation

samiib
Copy link

@samiib samiib commented Oct 17, 2023

  • Tested github actions workflow
  • Added format checks to workflow
  • Set Test ACI credentials based on GitHub Action secrets
  • Added extra log to gofmt script and add build check

…port muxing the provider with terraform plugin framework
…t muxed provider capabilities and migrate aci_annotation to new provider plugin framework
…etwork_instance_profile, aci_l3out_management_network_oob_contract, aci_l3out_management_network_subnet and aci_out_of_band_contract
…and clean up template and required attribute overwrite
…g in documentation, and clean up templates with generator
…mat ( .html.markdown ) to new documentation directory ( /docs ) and format ( .md )
…ST and GEN_CLASSES environment variables are set
…when annotation is contained by the class in the meta file
akinross and others added 14 commits October 6, 2023 09:41
- Manually migrating the aci_rest_managed resource from SDKv2 to the Plugin Framework.
- Moved Schema over to the new format.
- CRUD implementations for the resource.
- Migrated the data source
- Fixed generator to handle manual Aci_rest_managed object.
- Changed child to block format
- Fix dn description
- Correctly set ElementType on content map
- Correctly set id to dn
- Get ClassName from ACI json response if any
- Set contents based on attributes
- Make sure to ignore certain contents attributes from state
- Skip seting attributes into state when not configured in contents.
- Temporarily commented out child block logic as it's throwing an error while no child is configured.
- Removed old code
- Started migrating test files
2. I fixed the format of the children json being sent to APIC.
3. Also stopped extra children and extra child attributes from saving in the state. This was causing errors in Terraform.
- Log a warning when trying to delete a class that cannot be deleted instead of an error.
- Finished migrating existing aci_rest_managed tests.
 - Added extra acceptance test
 - Fixed classes that doesn't support   annotations.
 - Fixed error when rest response isn't json.
* Tested github actions workflow
* Added format checks to workflow
* Set Test ACI credentials based on GitHub Action secrets
* Added extra log to gofmt script and add build check
@akinross akinross force-pushed the plugin-framework-mux branch 7 times, most recently from ab13adb to 779ed58 Compare November 22, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants