Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate need to enable visibility of Docker containers in the extension #42

Merged
merged 8 commits into from
Apr 6, 2023

Conversation

jombooth
Copy link
Contributor

@jombooth jombooth commented Apr 6, 2023

leverage workaround from docker/extensions-sdk#225 (comment) to eliminate this startup dialog. H/t @versilis for leading us to this solution!

Container state data, as emitted from inspect:
image

@jombooth jombooth changed the title WIP: get around needing to enable visibility of Docker containers in the extension Eliminate need to enable visibility of Docker containers in the extension Apr 6, 2023
@jombooth jombooth requested a review from versilis April 6, 2023 01:14
Copy link
Member

@versilis versilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jombooth jombooth merged commit 8ff4fba into main Apr 6, 2023
@jombooth jombooth deleted the jo-list-containers-experiment branch April 6, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 – Blocking Fast turnaround requested—project is blocked Frontend - Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants