Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] stock_restrict_lot : actually assign and validate move instead … #7

Conversation

metaminux
Copy link

…of changing its state to done in tests

After fixing stock_owner_restriction in OCA#1736
Fixing tests for PR OCA#1560 as setting state is not enough to raise ValidationError

@github-grap-bot
Copy link

Hi @florian-dacosta,
some modules you are maintaining are being modified, check this out!

Copy link

codecov bot commented Oct 1, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@metaminux
Copy link
Author

@Kev-Roche Can you review and merge this one to help tests go green on OCA#1560 ?

@florian-dacosta
Copy link
Member

It is better to do the normal process in test rather than forcing state indeed.
I think assign is optional but it does not hurt

@florian-dacosta florian-dacosta merged commit 82a9133 into akretion:16.0-imp-propagation_of_restrict_lot_changes Oct 2, 2024
8 of 10 checks passed
@metaminux metaminux deleted the 16.0-imp-propagation_of_restrict_lot_changes branch October 2, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants