-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add native agent module #2915
add native agent module #2915
Conversation
能否在 agent server 上实现一个简单的 注册中心?避免有外部依赖才能启动。 |
...rver/src/main/java/com/alibaba/arthas/nat/agent/server/server/http/HttpResourcesHandler.java
Fixed
Show fixed
Hide fixed
可以的,我补充1下。但是这个agent server 只能管理注册到它的 agent client |
分两期来做吧,我尽量在这个月底完成。参考下别的注册中心实现,要点时间😄 |
在 webui 上的 websocket 连接,貌似是直连的 client 的端口 2672 。 这个要求用户和 client 是网络相通的。 实际上用户很多时候是没办法连接 client 所在的机器的。它只能连接 native-agent-server的机器。 需要把 ws 连接,从 native-agent-server 转发到 native-agent-client,再转发给 arthas 。 |
...rver/src/main/java/com/alibaba/arthas/nat/agent/server/server/http/HttpResourcesHandler.java
Fixed
Show fixed
Hide fixed
…-agent-management-web and rename native-agent-client to native-agent
if (normalizedPath == null) { | ||
return null; | ||
} | ||
URL resourceUrl = getClass().getResource(RESOURCES_BASE_PATH + normalizedPath); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
user-provided value
ctx.channel().attr(AttributeKey.valueOf("nativeAgentAddress")).set(nativeAgentAddress); | ||
} | ||
|
||
request.setUri(uri.getPath()); |
Check failure
Code scanning / CodeQL
Server-side request forgery Critical
add native agent module
native-agnet-client
native-agent-server