remove xDS support #347
Open
remove xDS support #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSmigielski
force-pushed
the
remove_xds_support
branch
from
86eea05
to
9fd2ce3
Compare
Ferdudas97
previously approved these changes
Nov 15, 2022
matb4r
previously approved these changes
Nov 15, 2022
Ferdudas97
previously approved these changes
Nov 18, 2022
matb4r
previously approved these changes
Nov 18, 2022
# Conflicts: # CHANGELOG.md # envoy-control-tests/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/EndpointMetadataMergingTests.kt
Ferdudas97
previously approved these changes
Feb 13, 2023
matb4r
previously approved these changes
Feb 15, 2023
| @@ -11,7 +11,7 @@ import pl.allegro.tech.servicemesh.envoycontrol.config.service.EchoServiceExtens | |||
| import pl.allegro.tech.servicemesh.envoycontrol.config.envoy.CallStats | |||
| import pl.allegro.tech.servicemesh.envoycontrol.config.envoy.EnvoyExtension | |||
|
|
|||
| interface ServiceTagsAndCanaryTestBase { | |||
| class ServiceTagsAndCanaryTestBase { | |||
There was a problem hiding this comment.
I think this is not related to xDS, but to custom test implementation in AEC. It may be still needed
# Conflicts: # CHANGELOG.md # envoy-control-core/src/main/resources/lua/ingress_rbac_logging.lua # envoy-control-tests/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/routing/ServiceTagsAndCanaryTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.