Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parseFunctionNames() parsing only the first function name (issue #13) #14

Open
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

psolaimani
Copy link

fixed function now correctly handles different edge cases.

testr:::parseFunctionNames(c("stats::hello","stats:::why","stats:::",":::","world","abc::def::gh"))

[[1]]
name package
"hello" "stats"

[[2]]
name package
"why" "stats"

[[3]]
name package
":" "stats"

[[4]]
name package
":::" NA

[[5]]
name package
"world" NA

[[6]]
name package
"def" "abc"

Warning message:
In testr:::parseFunctionNames(c("stats::hello", "stats:::why", "stats:::", :
badly formatted package name: abc::def::gh

@psolaimani psolaimani changed the title fix parseFunctionNames() parsing only the first function name. fix parseFunctionNames() parsing only the first function name (issue #13) Jun 24, 2016
@codecov-io
Copy link

codecov-io commented Jun 24, 2016

Current coverage is 35.78% (diff: 41.85%)

Merging #14 into master will increase coverage by 1.91%

@@             master        #14   diff @@
==========================================
  Files            10         11     +1   
  Lines          1001       1185   +184   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            339        424    +85   
- Misses          662        761    +99   
  Partials          0          0          

Powered by Codecov. Last update 5deae22...a52b6d8

parham and others added 26 commits August 26, 2016 15:58
- Run all test scripts in tests/ instead of just testthat (packages should
  be installed with "--install-tests" or NO tests will be run)
- Look for example source in R-ex (packages should be installed with --example)
- Invalid test cases are preserved for debugging purposes

The test generation code appears to be generating a large number of invalid
test cases (~ 90% invalid).
- Also run package examples via example() so that
  don't run / don't test is respected.
For some base packages there is a fair degree of tests
generated over and over again that don't need to be validated
each time.
Otherwise failed tests/examples can lead to
corrupted capture files that never get removed.
Does not seem to be working.
Will just set the current directory when running examples
The linux timeout tool will only send a TERM signal by default.
Adding the --kill-after flag will ensure that the script is sent
the KILL signal if it fails to exit cleanly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants