Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when creating quote via api #189

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrodespin
Copy link

Reason for change

When we are trying to create a quote using the Magento API we have the following error

{ "message": "No such entity with %fieldName = %fieldValue", "parameters": { "fieldName": "customerId", "fieldValue": 3 },

Code changes

Included a validation to not load quote by customer integration ids.

How to test

Create a new quote using following API Methods:

  1. rest/all/V1/carts/
  2. rest/all/V1/carts/{cart_id}/items
  3. rest/all/V1/carts/{cart_id}/estimate-shipping-methods
  4. rest/all/V1/carts/{cart_id}/shipping-information (This one fails)

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • [] The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

@mrodespin mrodespin requested a review from a team as a code owner August 19, 2024 09:15
Copy link

sonarcloud bot commented Aug 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant