Fix .webp SrcSet Creation Filter #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfuchss
changed the title
|
^^ This - I came to fix this same issue, and found someone already got to it! simple fix. |
dfuchss
changed the title
george-gca
requested changes
Oct 16, 2024
george-gca
approved these changes
Oct 16, 2024
|
Just missing the prettier fix. |
I don't know why prettier is requesting this because I only changed one line. But nevertheless, it's applied now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix .webp SrcSet Creation Filter
Description
This PR addresses an issue with the filter for creating
.webpsrcsets introduced in PR #2698. The original filter incorrectly searched for extensions with a leading period (e.g., ".jpg" and ".png"). As a result, no matches were found, preventing the srcset from being added to any figures. This occurred because the split operation removes the period from the file extensions.Changes Made
.webpsrcset to function as intended.Impact
With this change, responsive images will now correctly generate their srcsets for the appropriate file types, improving image loading performance and supporting better responsiveness.
Fixes
Please review the changes and let me know if there are any further adjustments needed. Thank you!