Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Revamp Okx #71

Open
wants to merge 109 commits into
base: master
Choose a base branch
from
Open

Feature - Revamp Okx #71

wants to merge 109 commits into from

Conversation

LucianoPierdona
Copy link
Contributor

@LucianoPierdona LucianoPierdona commented May 18, 2022 •
edited
Loading

Summary

Implement Okx under a new architecture.

Modules

  • Public
    • Symbol
    • Market
  • Authed
    • Key
    • Balance
    • Order
    • Position

Checklist

  • Build is passing
  • Coverage is at 100%
  • Integration tests are passing (important one!)
  • Configs added to Insomnia playground.json file
  • Exchange has a README.md file
  • Exchange specs added to exchanges-table.md file

@LucianoPierdona LucianoPierdona self-assigned this May 18, 2022
@LucianoPierdona
Add Okx Symbol schema and fixtures
2b47809
@LucianoPierdona
Add Okx Market schema and fixtures
ffaa3c9
@LucianoPierdona
Add Okx Key schema and fixtures
f614bd4
@LucianoPierdona
Add Okx Balance schema and fixtures
38d08aa
@LucianoPierdona
Add Okx Symbol parse many and test suite
17e2f0b
@LucianoPierdona
Add Okx Symbol parse and test suite
b3bdbc2
@LucianoPierdona
Add Okx Symbol list raw and test suite
f5a3440
@LucianoPierdona
Add Okx Market parse many
9657a0d
@LucianoPierdona
Add Okx Market parse and test suite
bc963ad
@LucianoPierdona
Add Okx Market list raw and test suite
fc1677b
@LucianoPierdona
Add Okx Key fetch details and test suite
40bcba3
@LucianoPierdona
Add Okx Balance list raw and test suite
3f33225
@LucianoPierdona
Add Okx Balance parse many
13ed458
@LucianoPierdona
Add Okx Balance parse and test suite
a8820ec
@LucianoPierdona
Add Okx symbol type enum
240c9bc
@LucianoPierdona
Add Okx symbol status enum
86e1d7c
@LucianoPierdona
Add Okx specs and test suite
92b881a
@LucianoPierdona
Add Okx http and test suite
219a7f1
@LucianoPierdona
Add Okx Order schema and fixtures
23026df
@LucianoPierdona
remove okx market status enum
02f7522
@LucianoPierdona
add okx order side enum
8293881
@LucianoPierdona
add okx order status enum
70eae9f
@LucianoPierdona
add okx order type enum
65b089d
@LucianoPierdona
add okx order side adapter and test suite
86bc511
@LucianoPierdona
add okx order status adapter and test suite
a560790
@LucianoPierdona
add okx order type adapter and test suite
7119d87
@LucianoPierdona
add okx order cancel and test suite
16d19db
Torres-ssf
Torres-ssf suggested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment •
edited by LucianoPierdona
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucianoPierdona mate we still have some pending tasks to do here:

  • Add OKX configs to Insomnia playground.json file
  • Make integration tests pass

src/exchanges/okx/modules/authed/balance/parseMany.ts Outdated Show resolved Hide resolved
test/e2e/configs.ts Outdated Show resolved Hide resolved
@LucianoPierdona
fixes to okx configs, schema and fixtures
0aeb594
@LucianoPierdona
fix okx place order
8f749a3
@LucianoPierdona
fix okx get raw
1c2f2d2
@LucianoPierdona
fix okx parse many calculation
d80ed31
@LucianoPierdona
fix okx order parse to include baseSymbolId and quoteSymbolId
27bfef5
@LucianoPierdona
Merge remote-tracking branch 'origin/master' into feature/revamp-okx
1085131
@LucianoPierdona
update e2e configs for okx
45aed94
@LucianoPierdona
update okx order fixtures and schemas
2f07507
@LucianoPierdona
update okx list test suites
3e29fd0
@LucianoPierdona
update okx order place and test suite
4e06a9a
@LucianoPierdona
update okx specs
3a4aac9
@LucianoPierdona
update okx order type adapter to include STOP_MARKET orders
4b5f483
@LucianoPierdona
update okx request error to test code
23e57b5
@LucianoPierdona
update cancel order to support STOP orders
698b876
@LucianoPierdona
update okx edit order to support STOP orders
681177f
@LucianoPierdona
update get okx raw order to support closed and open STOP orders
6ac8b0b
@LucianoPierdona
update okx parse to include proper fields for each order type
175ec16
@LucianoPierdona
linting
e95d491
@LucianoPierdona
update aluna-spec file
66ddd14
@LucianoPierdona LucianoPierdona marked this pull request as ready for review June 13, 2022 12:12
@arboleya
Copy link
Contributor

@LucianoPierdona It looks like you forgot to update the exchanges-table.md regarding OKX:

I'm not sure if the position module here refers to Margin or Derivatives, but here's how it is:

specs

@LucianoPierdona
Copy link
Contributor Author

LucianoPierdona commented Jun 15, 2022 •
edited
Loading

@LucianoPierdona It looks like you forgot to update the exchanges-table.md regarding OKX:

I'm not sure if the position module here refers to Margin or Derivatives, but here's how it is:

specs

@arboleya updated specs together with some other small updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya left review comments

@Torres-ssf Torres-ssf Torres-ssf requested changes

Assignees

@LucianoPierdona LucianoPierdona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucianoPierdona @arboleya @Torres-ssf