-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LEX improvement #1204
base: master
Are you sure you want to change the base?
LEX improvement #1204
Conversation
@orimay 🔥 it looks right, the LEX tests are passing. Deleting my lines of code is the best gold a JSgolfer like me can receive :D :D pure outgamed bliss, I bow to you, this is Objective Truth, Scientific Beauty, and makes my heart sing.
|
Which test would that be? |
@orimay https://github.com/amark/gun/blob/master/test/sea/sea.js#L566-L701 . I hope you're talents & brain are in a healthy place! |
if(u !== o['>'] && t >= o['>']){ return true } | ||
if(u !== o['<'] && t <= o['<']){ return true } | ||
return false; | ||
String.match = function(t, o){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add //target, other comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is useful or not to you guys, but for new people might help,
Some sections could probably be added to lex docs somewhere.
I moved this to here so its more findable. If your working on it again at some point maybe take a look and let me know if i am missing something.
https://github.com/amark/gun/wiki/Strings,-Keys-and-Lex-Rules
Must be ES5-compatible. Passes 'match text' test ;)