client: handle disconnections better #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so server logs are more readable
1. close all the channels upon a disconnection 2. don't try to write to them if we've initiated a disconnection 3. check for ErrCloseSent from gorilla/websocket
andreykaipov
force-pushed
the
feature/client-improvements
branch
from
6ad6124
to
64b92f8
Compare
andreykaipov
added
bug
Closed
This was referenced Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases of highly concurrent clients, there seems to be some bugs when disconnecting and still trying to write to the closed websocket connection or to the internal channels used. These added checks should hopefully prevent most of those panics. 🤞
For some reason this was more prevalent when using gorilla/websocket v1.5.1 instead of v1.5.0 (#64).
Also changes most of the DEBUG logs to TRACE logs.