-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for wrap.sh based HWASan #951
Conversation
@emrekultursay FYI. The problem here is that I didn't know how to change the API level for the HWASan build only. |
Try adding this to your
|
That works. PTAL. |
Tested by checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@emrekultursay for some reason it says "At least 1 approving review is required by reviewers with write access", also the presubmit build is failing with unrelated lint errors. Do you know how to fix these? My theory is that clang-format got somehow updated so now the code mismatches. |
I am not an owner of this repo. I believe @DanAlbert or @enh-google can help. |
Rebased and presubmit checks are now passing, PTAL. @DanAlbert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expanded the comment attached to minSdk to explain that it's not always true. The other comment I had is one I'll have to leave to you though. Otherwise LGTM.
No description provided.