Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies used in hello-vulkan. #952

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

DanAlbert
Copy link
Member

No description provided.

@DanAlbert DanAlbert requested a review from jfgoog July 28, 2023 20:00
@DanAlbert
Copy link
Member Author

Hmm, that build failure is annoying:

FAILURE: Build failed with an exception.

* Where:
Build file '/home/runner/work/ndk-samples/ndk-samples/hello-vulkan/app/build.gradle' line: 17

* What went wrong:
A problem occurred evaluating project ':app'.
> Failed to apply plugin 'com.android.internal.application'.
   > Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
      Your current JDK is located in /opt/hostedtoolcache/jdk/11.0.20/x[64](https://github.com/android/ndk-samples/actions/runs/5695821544/job/15439743773?pr=952#step:7:65)
      You can try some of the following options:
       - changing the IDE settings.
       - changing the JAVA_HOME environment variable.
       - changing `org.gradle.java.home` in `gradle.properties`.

I changed it to 17 for the same error I had locally. Might be that we need to update the JDK used on the buildbot to match the one used by newer versions of Studio?

@DanAlbert
Copy link
Member Author

(I know the "new" NDK here is now old, but it's an old PR)

@DanAlbert DanAlbert merged commit be0ebf2 into android:main Jan 11, 2024
2 checks passed
@DanAlbert DanAlbert deleted the update-hello-vulkan-deps branch January 11, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants