Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix: set display: flex for sidenav by default #12083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ersachin3112
Copy link

@ersachin3112 ersachin3112 commented Mar 23, 2021

PR Checklist

Please check your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Fixes #10040

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

No

@google-cla
Copy link

google-cla bot commented Mar 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Mar 23, 2021
@ersachin3112
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Mar 23, 2021
@Splaktar Splaktar self-requested a review April 7, 2021 01:58
@Splaktar Splaktar self-assigned this Apr 7, 2021
@Splaktar Splaktar added P3: important Important issues that really should be fixed when possible. type: bug labels Apr 7, 2021
@Splaktar Splaktar added the needs: manual testing This issue or PR needs to have some manual testing and verification done label Jul 22, 2021
@Splaktar
Copy link
Member

This is likely not something that we can get merged during the LTS. It would have been possible to consider it last July for the 1.2.0 release since this change is likely to break some apps.

For now, it's probably best to just override this style in your app.

@Splaktar Splaktar added - Breaking Change resolution: too risky There is too much risk or disruption with this proposal for our limited resources. labels Jul 22, 2021
@Splaktar Splaktar added this to the 1.3.0 milestone Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
- Breaking Change cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ needs: manual testing This issue or PR needs to have some manual testing and verification done P3: important Important issues that really should be fixed when possible. resolution: too risky There is too much risk or disruption with this proposal for our limited resources. type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidenav: should be display: flex by default
3 participants