Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4.0 release to devel #338

Merged
merged 49 commits into from
Jun 19, 2024
Merged

V4.0 release to devel #338

merged 49 commits into from
Jun 19, 2024

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Jun 13, 2024

Overall Review of Changes:
New v4.0 CIS benchmark playbook - refer to CIS documentation for changes
New workflow setup

How has this been tested?:
Manually

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly requested a review from MrSteve81 June 13, 2024 07:34
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Copy link
Member Author

uk-bolly commented Jun 13, 2024

Workflow will cause issues due to time amazon now taking before we are able to connect, unable to adjust timeout on the workflow as it stands
Have run locally on two different systems to prove output

ok: [cent7_bios] => {
    "msg": [
        "The pre remediation results are: Count: 623, Failed: 208, Skipped: 30, Duration: 6.052s.",
        "The post remediation results are: Count: 623, Failed: 11, Skipped: 2, Duration: 7.655s.",
        "Full breakdown can be found in /opt",
        ""
    ]
}
ok: [cent7_efi] => {
    "msg": [
        "The pre remediation results are: Count: 623, Failed: 208, Skipped: 30, Duration: 5.739s.",
        "The post remediation results are: Count: 623, Failed: 13, Skipped: 2, Duration: 8.939s.",
        "Full breakdown can be found in /opt",
        ""
    ]
}

TASK [/Users/uk-bolly/RHEL7-CIS : Output Warning count and control IDs affected] ***************************
ok: [cent7_bios] => {
    "msg": "You have 6 warning(s) that require investigating that are related to the following benchmark ID(s)  [1.1.2.2.1] [1.2.4] [2.2.22] [3.4.2.3] [3.4.2.4] [Reboot_required]"
}
ok: [cent7_efi] => {
    "msg": "You have 6 warning(s) that require investigating that are related to the following benchmark ID(s)  [1.1.2.2.1] [1.2.4] [2.2.22] [3.4.2.3] [3.4.2.4] [Reboot_required]"
}

@uk-bolly uk-bolly marked this pull request as ready for review June 13, 2024 08:46
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly requested review from georgenalen and removed request for MrSteve81 June 19, 2024 14:41
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
georgenalen
georgenalen previously approved these changes Jun 19, 2024
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: Mark Bolwell <[email protected]>
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@georgenalen
Copy link
Contributor

Due to how the pipeline works and some changes the devel pipeline action will fail. This has been tested successfully locally.

@uk-bolly uk-bolly merged commit f23295a into devel Jun 19, 2024
3 of 4 checks passed
@uk-bolly uk-bolly deleted the v4.0 branch June 19, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants