Update ec2 resource names inline with issue #89. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robg-test
reviewed
Aug 4, 2023
| policy_arn = each.value | ||
| } | ||
|
|
||
| resource "tls_private_key" "private_key" { | ||
| resource "tls_private_key" "this" { |
There was a problem hiding this comment.
I would name this on the lines of self_generated or self_managed
This could be misinterpreted as always being the key which in some scenarios it won't be (e.g. You provide your own key)
| count = var.custom_key_name == "" ? 1 : 0 | ||
| algorithm = "RSA" | ||
| rsa_bits = 4096 | ||
| } | ||
|
|
||
| resource "aws_key_pair" "key_pair" { | ||
| resource "aws_key_pair" "this" { |
There was a problem hiding this comment.
Again see previous comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.