-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add iconFontTypes to get all iconfont types #463
Open
mrlmx
wants to merge
4
commits into
ant-design:master
Choose a base branch
from
mrlmx:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@afc163 Hi,偏右大大,可以帮忙看看这段代码么。 主要是为了方便的获取当前 iconfont 链接中的所有 icon,在项目中,可以通过此方法,展示一个 icon 列表,方便筛选 icon。 |
/rebase |
@afc163 Hi,请问一下
|
我明白了, 不过我好像犯了一个错误,就是直接在 master 上提交的。导致 rebase 的时候失败了。
这种场景下,是要我单独切个分支提交之后,再重新发起一个 pr 么 |
你可以手动 rebase 一下源仓库远程 master,再 push --force。 |
use fetch to load scriptUrl and match all iconfont types
已完成 😁 |
来个测试用例? |
ok,我抽空完善一下 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use fetch to load scriptUrl and match all iconfont types