fix(CanlendarPicker): component freezes when the time interval is too… #6766
+290
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zombieJ
reviewed
Oct 24, 2024
| @@ -71,6 +71,8 @@ | |||
| "rc-util": "^5.38.1", | |||
| "react-fast-compare": "^3.2.2", | |||
| "react-is": "^18.2.0", | |||
| "react-virtualized-auto-sizer": "^1.0.24", | |||
| "react-window": "^1.8.10", | |||
There was a problem hiding this comment.
另外，package lock 文件删一下
好的收到 我尝试下 rc-virtual-list
zombieJ
reviewed
Oct 24, 2024
| // 遍历月份 | ||
| const totalMonths = Math.ceil(maxDay.diff(minDay, 'months', true)) | ||
| // default 每个月的高度是 344px | ||
| const monthHeight = 344 |
There was a problem hiding this comment.
OMG 那改怎么修改, 虚拟滚动需要一个定高才行 o(╥﹏╥)o
There was a problem hiding this comment.
哦我鸡道了,我这个变量初始是 344，然后初始化的时候统计计算一下用户设置的高度，再修改这个 monthHeight 的值，我还注意到renderDate这个 props 也会影响到高度，所以写死是不 ok 的，我尝试改一下
… large, using virtual scrolling optimization
LLmoskk
force-pushed
the
fix-CalendarPicker-virtualized
branch
from
8a3afca
to
b8a572a
Compare
|
@zombieJ 大佬我搞了个新版本解决用户自定义日历的话高度不可以固定写死值，整理了下之前的代码逻辑。思路是renderPlaceholderMonths 创建的 dom 放在组件里，然后获取到可被内容撑开 的 dom 元素，获取到他的高度也就是用户自定义后的高度后再告诉虚拟滚动 List 使用这个高度，测试方式我用src/components/calendar-picker/demos/demo3.less:91 文件修改了 height |
LLmoskk
force-pushed
the
fix-CalendarPicker-virtualized
branch
from
69f1aed
to
99bb852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
component freezes when the time interval is too large, using virtual scrolling optimization
#6710 尝试修复此问题，使用了虚拟滚动避免 dom 数量过多引起的卡顿