fix: 兼容在 React 19 环境下的 Toast 组件 #6774
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6774 +/- ##
=======================================
Coverage 92.70% 92.70%
=======================================
Files 335 335
Lines 7199 7200 +1
Branches 1767 1768 +1
=======================================
+ Hits 6674 6675 +1
Misses 517 517
Partials 8 8 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Nov 4, 2024
src/utils/render.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| import type { ReactElement } from 'react' | |||
| import * as ReactDOM from 'react-dom' | |||
| import type { Root } from 'react-dom/client' | |||
| import { type Root, createRoot as createClientRoot } from 'react-dom/client' | |||
zombieJ
reviewed
Nov 5, 2024
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| createRoot = fullClone.createRoot | ||
| const { createRoot: createRootV18 } = require('react-dom/client') |
There was a problem hiding this comment.
这样也没用，webpack 编译时也会报错。在 antd 侧也有一样的问题，这个只能通过发大版本把旧版本的 react 支持废弃掉才行。
|
这个能否尽快发个版啊，同样遇到这个问题了 |
|
版本发了吗？为什么还是不行啊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6635