Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84: Migrating DELETE queued asset events for assets to FASTAPI #44138

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vatsrahul1001
Copy link
Collaborator

Related: #42370

Swagger Specs
image
image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 18, 2024
@vatsrahul1001 vatsrahul1001 added legacy api Whether legacy API changes should be allowed in PR and removed legacy api Whether legacy API changes should be allowed in PR labels Nov 18, 2024
@vatsrahul1001 vatsrahul1001 force-pushed the AIP84-delete-assets-queued-event-new branch from 3f13e6d to 7d7a311 Compare November 18, 2024 13:07
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ready to merge, restarting failed checks

@pierrejeambrun
Copy link
Member

Won't pass, tests need fixing

@vatsrahul1001
Copy link
Collaborator Author

Won't pass, tests need fixing

taking a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants