Skip to content

Commit

Permalink
chore(ci): stop building for Python 3.8 (#2131)
Browse files Browse the repository at this point in the history
Fixes #2129.
  • Loading branch information
lidavidm authored Sep 9, 2024
1 parent 9633f08 commit 2f73da1
Show file tree
Hide file tree
Showing 13 changed files with 15 additions and 34 deletions.
2 changes: 1 addition & 1 deletion .env
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ JDK=8
MANYLINUX=2014
MAVEN=3.6.3
PLATFORM=linux/amd64
PYTHON=3.8
PYTHON=3.9
GO=1.21.8
ARROW_MAJOR_VERSION=14
DOTNET=8.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/native-unix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ jobs:
strategy:
matrix:
os: ["macos-13", "macos-latest", "ubuntu-latest"]
python: ["3.9", "3.11"]
python: ["3.9", "3.12"]
env:
# Required for macOS
# https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
Expand Down
22 changes: 1 addition & 21 deletions .github/workflows/packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -616,14 +616,6 @@ jobs:
adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl
adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl
- name: Test wheel 3.8
env:
ARCH: ${{ matrix.arch }}
PLATFORM: ${{ matrix.platform }}
run: |
pushd adbc
env PYTHON=3.8 docker compose run python-wheel-manylinux-test
- name: Test wheel 3.9
env:
ARCH: ${{ matrix.arch }}
Expand Down Expand Up @@ -728,11 +720,10 @@ jobs:
if: matrix.arch == 'amd64'
run: |
pushd adbc
sudo ci/scripts/install_python.sh macos 3.8
sudo ci/scripts/install_python.sh macos 3.9
popd
- name: Install Python (AMD64 only)
- name: Install Python
run: |
pushd adbc
sudo ci/scripts/install_python.sh macos 3.10
Expand Down Expand Up @@ -762,17 +753,6 @@ jobs:
adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl
adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl
- name: Test wheel 3.8
if: matrix.arch == 'amd64'
run: |
pushd adbc
/Library/Frameworks/Python.framework/Versions/3.8/bin/python3.8 -m venv test-env-38
source test-env-38/bin/activate
export PYTHON_VERSION=3.8
./ci/scripts/python_wheel_unix_test.sh $(pwd)
deactivate
- name: Test wheel 3.9
if: matrix.arch == 'amd64'
run: |
Expand Down
3 changes: 1 addition & 2 deletions ci/scripts/install_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ platforms=([windows]=Windows
[linux]=Linux)

declare -A versions
versions=([3.8]=3.8.10
[3.9]=3.9.13
versions=([3.9]=3.9.13
[3.10]=3.10.11
[3.11]=3.11.8
[3.12]=3.12.2)
Expand Down
3 changes: 2 additions & 1 deletion ci/scripts/python_util.sh
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ function setup_build_vars {
export CIBW_BUILD='*-manylinux_*'
export CIBW_PLATFORM="linux"
fi
export CIBW_SKIP="pp* ${CIBW_SKIP}"
# No PyPy, no Python 3.8
export CIBW_SKIP="pp* cp38-* ${CIBW_SKIP}"
}

function test_packages {
Expand Down
1 change: 1 addition & 0 deletions dev/release/verify-release-candidate.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ New-Item -ItemType Directory -Force -Path $CppBuildDir | Out-Null
# XXX(apache/arrow-adbc#634): not working on Windows due to it picking
# up MSVC as the C compiler, which then blows up when /Werror gets
# passed in by some package
$env:BUILD_DRIVER_BIGQUERY = "0"
$env:BUILD_DRIVER_FLIGHTSQL = "0"
$env:BUILD_DRIVER_SNOWFLAKE = "0"

Expand Down
4 changes: 2 additions & 2 deletions dev/release/verify-release-candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -825,7 +825,7 @@ test_linux_wheels() {
local arch="x86_64"
fi

local python_versions="${TEST_PYTHON_VERSIONS:-3.9 3.10 3.11}"
local python_versions="${TEST_PYTHON_VERSIONS:-3.9 3.10 3.11 3.12}"

for python in ${python_versions}; do
local pyver=${python/m}
Expand All @@ -847,7 +847,7 @@ test_macos_wheels() {
local platform_tags="x86_64"
fi

local python_versions="${TEST_PYTHON_VERSIONS:-3.9 3.10 3.11}"
local python_versions="${TEST_PYTHON_VERSIONS:-3.9 3.10 3.11 3.12}"

# verify arch-native wheels inside an arch-native conda environment
for python in ${python_versions}; do
Expand Down
2 changes: 1 addition & 1 deletion python/adbc_driver_bigquery/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ description = "An ADBC driver for working with BigQuery."
authors = [{name = "Apache Arrow Developers", email = "[email protected]"}]
license = {text = "Apache-2.0"}
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
dynamic = ["version"]
dependencies = [
"adbc-driver-manager",
Expand Down
2 changes: 1 addition & 1 deletion python/adbc_driver_flightsql/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ description = "An ADBC driver for working with Apache Arrow Flight SQL."
authors = [{name = "Apache Arrow Developers", email = "[email protected]"}]
license = {text = "Apache-2.0"}
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
dynamic = ["version"]
dependencies = [
"adbc-driver-manager",
Expand Down
2 changes: 1 addition & 1 deletion python/adbc_driver_manager/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ description = "A generic entrypoint for ADBC drivers."
authors = [{name = "Apache Arrow Developers", email = "[email protected]"}]
license = {text = "Apache-2.0"}
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
dynamic = ["version"]
dependencies = ["typing-extensions"]

Expand Down
2 changes: 1 addition & 1 deletion python/adbc_driver_postgresql/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ description = "A libpq-based ADBC driver for working with PostgreSQL."
authors = [{name = "Apache Arrow Developers", email = "[email protected]"}]
license = {text = "Apache-2.0"}
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
dynamic = ["version"]
dependencies = [
"adbc-driver-manager",
Expand Down
2 changes: 1 addition & 1 deletion python/adbc_driver_snowflake/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ description = "An ADBC driver for working with Snowflake."
authors = [{name = "Apache Arrow Developers", email = "[email protected]"}]
license = {text = "Apache-2.0"}
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
dynamic = ["version"]
dependencies = [
"adbc-driver-manager",
Expand Down
2 changes: 1 addition & 1 deletion python/adbc_driver_sqlite/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ description = "An ADBC driver for working with SQLite."
authors = [{name = "Apache Arrow Developers", email = "[email protected]"}]
license = {text = "Apache-2.0"}
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
dynamic = ["version"]
dependencies = [
"adbc-driver-manager",
Expand Down

0 comments on commit 2f73da1

Please sign in to comment.