refactor(c/driver): Use non-objects framework components in Postgres driver #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
commented
Sep 20, 2024
Comment on lines
-193
to
-196
| dm.True(rdr.Next()) | ||
|
|
||
| rec := rdr.Record() | ||
| dm.Equal(int64(0), rec.NumRows()) |
There was a problem hiding this comment.
@zeroshade The change that triggered this was that the internal helper that generates streams from arrays will now canonically generate an empty stream instead of a stream with one array of length zero. I think this is slightly nicer but can revert it if you think it will cause problems!
lidavidm
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formalizes the names of documents the helpers in
framework/objects.handframeworks/utility.h. It also uses them in the PostgreSQL driver and removes duplicate functionality where possible (GetObjects in the Postgres driver is a bit of a bigger project for another PR).