-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CALCITE-3592] Implement BITNOT scalar function #3983
base: main
Are you sure you want to change the base?
Conversation
normanj-bitquill
commented
Sep 26, 2024
- Implemented the BITNOT scalar function as a standard function
- Supports integer and binary arguments
- Returns NULL if the argument is NULL
* Implemented the BITNOT scalar function as a standard function * Supports integer and binary arguments * Returns NULL if the argument is NULL
@@ -15738,6 +15738,29 @@ private static void checkLogicalOrFunc(SqlOperatorFixture f) { | |||
true); | |||
} | |||
|
|||
@Test void testBitNotScalarFunc() { | |||
final SqlOperatorFixture f = fixture(); | |||
f.setFor(SqlStdOperatorTable.BITXOR, VmName.EXPAND); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XOR?
How about a failing test with DECIMAL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that using XOR had not impact on the tests. Fixed now.
Also added a test for BITNOT(DECIMAL)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that setFor is just decorative
Quality Gate passedIssues Measures |
@@ -15738,6 +15738,35 @@ private static void checkLogicalOrFunc(SqlOperatorFixture f) { | |||
true); | |||
} | |||
|
|||
@Test void testBitNotScalarFunc() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add jira link