[CALCITE-6605] Lattice SQL supports complex column expressions #3987
Conversation
| /** Test case for | ||
| * <a href="https://issues.apache.org/jira/browse/CALCITE-6605">[CALCITE-6605] | ||
| * Lattice SQL supports complex column expressions </a>. */ | ||
| @Test void testExpressionLatticeSql() throws Exception { |
There was a problem hiding this comment.
Maybe you can add some blank lines or a method to make the test sample code more readable.🤔
There was a problem hiding this comment.
Added description for tests.
| return new SqlImplementor.SimpleContext(dialect, fieldFuncRef[0]) | ||
| .toSql(null, ((DerivedColumn) column).e); | ||
| } | ||
| throw new UnsupportedOperationException(); |
There was a problem hiding this comment.
This probably should have some more descriptive error
There was a problem hiding this comment.
It will be called when lattice column generates sql.
final Column column = columns.get(i);
column.toSql(w);
Originally, for DerivedColumn, the UnsupportedOperationException will be thrown directly. This PR will obtain the corresponding column based on index and return the field object.
Currently there are only two types of columns: BaseColumn, DerivedColumn, theoretically no exception will be thrown. But in order to avoid extreme cases that are not covered, the logic of throwing exceptions before is also retained.
|
mihaibudiu
added
the
LGTM-will-merge-soon
https://issues.apache.org/jira/browse/CALCITE-6605