fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415) #310

alpesh12 · 2018-01-25T13:48:08Z

Platforms affected

iOS

What does this PR do?

Does not crash the Cordova app which uses the plugin with corrupted image

What testing has been done on this change?

Tested with cordova-ios : 4.5.4

Checklist

Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
Reported an issue in the JIRA database
Added automated test coverage as appropriate for this change.

alpesh12 · 2018-01-26T05:39:32Z

@jcesarmobile
Can you please check with travis test its failed because of "The Sauce VMs failed to start the browser or device."

alsorokin · 2018-01-26T08:04:21Z

@alpesh12 from what I see, cd tests/ios && npm install && npm test has failed with the following error:

/Users/travis/build/apache/cordova-plugin-camera/src/ios/CDVCamera.m:373:36: error: variable is not assignable (missing __block type specifier)
                              data = imageData;
                              ~~~~ ^
1 error generated.

alsorokin · 2018-01-26T08:06:09Z

All the following errors are because of the failed build. Not sure why paramedic continues the test run after a build failure though...

shazron · 2018-01-26T08:18:26Z

src/ios/CDVCamera.m

+                        PHImageRequestOptions *option = [PHImageRequestOptions alloc];
+                        option.synchronous = true;
+                        [manager requestImageDataForAsset:asset options:option resultHandler:^(NSData *imageData, NSString *dataUTI, UIImageOrientation orientation, NSDictionary *info) {
+                              data = imageData;


This is the error that @alsorokin pointed out. Inherently this whole PR has to be re-worked since here on this line, this an async block (a callback) that resides in a synchronous function. For this to work, the processImage function has to be async, and changing that is not trivial.

@shazron
Its default functionality from PHFetchResult lib to return data from block to function, so it must be synchronous operation.
Let me know if you have other reference or solution to solved this bug.

shazron · 2018-01-27T01:57:28Z

Looks like the CI failures are paramedic related -- iOS tests pass which is good. I'll have to do a full review based on the new commits and test manually.

jcesarmobile · 2018-01-28T15:31:51Z

I've checked the code and the geolocation part won't work with this changes. Also adds code duplication and commented code. And the code to avoid the crash is only present for the case that there is no image changes (such as quality, resolution, etc).

BTW, as on the Android PR, the problem is not the corrupt image itself, but the increase of memory needed to handle it. The corrupt image works correctly with the old code in iPhone X and iPad pro, but crash the app on an iPod touch.

I like the idea of using Photos Framework to get the images, but it still requires more changes before it can be merged.

alpesh12 · 2018-01-29T05:38:55Z

@jcesarmobile Yes correct its old code working in iPhoneX and iPad pro also its issue of Out of memory exception iPhone5.
With Photos Framework there is no change for image quality and update code for geolocation

alpesh12 · 2018-02-01T13:02:37Z

@jcesarmobile @shazron
Any updates regarding merge

jcesarmobile · 2018-02-01T14:04:17Z

Sorry, I have no time to review the changes at this moment, as I told you on a previous PR, I do this in my spare time and I don't have spare time right now

jayeshthanki903 · 2018-02-13T07:42:30Z

+1

LiDhaval · 2018-02-19T09:31:24Z

+1 It will be really helpful if we get this piece of code.

alpesh12 · 2018-02-22T13:36:57Z

@jcesarmobile
Any updates for merge please?

LiDhaval · 2018-02-28T13:56:58Z

@jcesarmobile Please check if you got some free time this weekend. I have tested this and working fine for me.

ShemrickFlannigan · 2018-02-28T16:26:10Z

@shazron +1 For this fix; it solves several issues that we're experiencing with corrupt and/or large images. Requesting a review of this Pull Request for a merge

jd0048 · 2018-03-05T14:25:18Z

@jcesarmobile @shazron @alsorokin
Have you got a chance to take a look and merge this code?
i am requesting you to merge code asap.
Thank you

alsorokin · 2018-03-06T05:51:31Z

There's still one test failure, is it expected?

Test Case '-[CameraTest testProcessImage]' started.
2018-02-28 14:10:55.751 xctest[2330:8469] -[CDVCamera processImage:info:options:]: unrecognized selector sent to instance 0x7976c770
/Users/travis/build/apache/cordova-plugin-camera/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m:481: error: -[CameraTest testProcessImage] : failed: caught "NSInvalidArgumentException", "-[CDVCamera processImage:info:options:]: unrecognized selector sent to instance 0x7976c770"
(
	0   CoreFoundation                      0x00c96ded __exceptionPreprocess + 189
	1   libobjc.A.dylib                     0x00761d6f objc_exception_throw + 49
	2   CoreFoundation                      0x00d085b8 -[NSObject(NSObject) doesNotRecognizeSelector:] + 136
	3   CoreFoundation                      0x00c1ca8d ___forwarding___ + 941
	4   CoreFoundation                      0x00c1c6be _CF_forwarding_prep_0 + 14
	5   CDVCameraLibTests                   0x0edb4568 -[CameraTest testProcessImage] + 648
	6   CoreFoundation                      0x00c1df4d __invoking___ + 29
	7   CoreFoundation                      0x00c1de81 -[NSInvocation invoke] + 321
	8   XCTest                              0x0066442b __24-[XCTestCase invokeTest]_block_invoke_2 + 502
	9   XCTest                              0x006a4b0a -[XCTestContext performInScope:] + 229
	10  XCTest                              0x00664228 -[XCTestCase invokeTest] + 259
	11  XCTest                              0x00664bc5 -[XCTestCase performTest:] + 621
	12  XCTest                              0x006949b7 -[XCTest runTest] + 45
	13  XCTest                              0x00661a39 __27-[XCTestSuite performTest:]_block_invoke + 258
	14  XCTest                              0x0066160b -[XCTestSuite _performProtectedSectionForTest:testSection:] + 32
	15  XCTest                              0x0066181b -[XCTestSuite performTest:] + 213
	16  XCTest                              0x006949b7 -[XCTest runTest] + 45
	17  XCTest                              0x00661a39 __27-[XCTestSuite performTest:]_block_invoke + 258
	18  XCTest                              0x0066160b -[XCTestSuite _performProtectedSectionForTest:testSection:] + 32
	19  XCTest                              0x0066181b -[XCTestSuite performTest:] + 213
	20  XCTest                              0x006949b7 -[XCTest runTest] + 45
	21  XCTest                              0x00661a39 __27-[XCTestSuite performTest:]_block_invoke + 258
	22  XCTest                              0x0066160b -[XCTestSuite _performProtectedSectionForTest:testSection:] + 32
	23  XCTest                              0x0066181b -[XCTestSuite performTest:] + 213
	24  XCTest                              0x006949b7 -[XCTest runTest] + 45
	25  XCTest                              0x006b0bdf __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 52
	26  XCTest                              0x00671af7 -[XCTestObservationCenter _observeTestExecutionForBlock:] + 699
	27  XCTest                              0x006b0a72 -[XCTTestRunSession runTestsAndReturnError:] + 295
	28  XCTest                              0x0064be10 -[XCTestDriver runTestsAndReturnError:] + 255
	29  XCTest                              0x006a83a1 _XCTestMain + 790
	30  xctest                              0x0008bab2 xctest + 6834
	31  libdyld.dylib                       0x020e6779 start + 1
)
Test Case '-[CameraTest testProcessImage]' failed (0.229 seconds).

alsorokin · 2018-03-06T05:52:37Z

I've tried restarting tests and it's still there

jd0048 · 2018-03-06T05:58:45Z

@alsorokin i think its not expected, iOS test already passed
This error comes because of TEST_DIR=./tests/ios in this test its referring old signature of function.

alsorokin · 2018-03-06T07:00:47Z

I see. Well, If you've changed the function signature, I guess you should also change the test to pass that new argument to it.

jd0048 · 2018-03-06T07:02:02Z

How can i do that?

alsorokin · 2018-03-06T07:07:33Z

This is the line that is failing:
https://github.com/apache/cordova-plugin-camera/blob/master/tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m#L481

Hope that helps :)

jd0048 · 2018-03-06T07:08:53Z

But this iOS test already passed.

alsorokin · 2018-03-06T07:39:12Z

I'm not sure what you mean.
it is failed here:
https://travis-ci.org/apache/cordova-plugin-camera/jobs/334579377#L1781

jd0048 · 2018-03-06T08:55:43Z

@alsorokin
i had test locally its showing build success for me.

jd0048 · 2018-03-06T09:20:27Z

@alsorokin
Also check above comment from @shazron

alsorokin · 2018-03-06T09:46:54Z

Well I guess we have to wait until he reviews it then.
I don't have enough expertise in iOS to merge it anyway :)

jd0048 · 2018-03-07T07:04:24Z

@shazron Can you please check and merge code.

alpesh12 · 2018-03-22T09:30:48Z

@jcesarmobile @shazron
Can you please help me to merge this code to the master, i am waiting from last one month.

jcesarmobile · 2018-03-22T09:49:39Z

I have a long list of things to review/merge, and every time somebody pings me or comment with +1 on the PR trying to rush it, I move it to the bottom of my list.

For people commenting with +1, please, stop doing it. GitHub added the reactions long time ago, if you reaction with +1 on the PR instead of a +1 comment, then we can sort the PRs by the reactions and know which one has more +1, while a comment just spams everybody subscribed and piss off collaborators like me.

alpesh12 · 2018-03-22T09:53:52Z

@jcesarmobile
when you are available to check this PR and merge?
i am waiting from last 30 days.

jcesarmobile · 2018-03-22T10:11:15Z

So, you didn't read my comment or you didn't care and pinged me again trying to rush me, so I just removed it from my list.
I understand that you need this and you want this merged as soon as possible, but there are hundreds of PRs at this moment, most of them are older than yours. We don't have enough resources to review and merge everything, we have to prioritize. And after you comment, this PR is no longer a priority for me.
I'm unsubscribing from the notifications, please, don't ping me again.

alpesh12 · 2018-03-22T10:16:28Z

@jcesarmobile
i am really sorry. i didn’t mean to disturb you. Just wanted to follow up with you regarding merge. But i understand your work load so please take care of it when you get a time. Again sorry for bugging you.
Thank you

janpio · 2018-10-02T20:14:45Z

1 test failure left:

Test Case '-[CameraTest testProcessImage]' failed (0.174 seconds).
Test Case '-[CameraTest testRetrieveImage]' started.
Test Case '-[CameraTest testRetrieveImage]' passed (0.316 seconds).
Test Suite 'CameraTest' failed at 2018-09-30 01:20:33.535.
	 Executed 7 tests, with 1 failure (1 unexpected) in 5.831 (5.848) seconds
Test Suite 'CDVCameraLibTests.xctest' failed at 2018-09-30 01:20:33.537.
	 Executed 7 tests, with 1 failure (1 unexpected) in 5.831 (5.852) seconds
Test Suite 'All tests' failed at 2018-09-30 01:20:33.543.
	 Executed 7 tests, with 1 failure (1 unexpected) in 5.831 (5.858) seconds
Failing tests:
	-[CameraTest testProcessImage]

janpio · 2019-07-04T10:40:09Z

@alpesh12 Could you please take a look at the remaining test failure? Shouldn't be too hard to fix, then we can properly review this PR and see if it can be merged. Thanks.

Camera plugin issue for corrupted image iOS

8eafce0

shazron requested changes Jan 26, 2018

View reviewed changes

alpesh12 and others added 2 commits January 26, 2018 14:44

Chaged block return statement

e81b825

Added async image processing as author suggest

2048c0c

solved geolocation bug and removed extra comments

2b854a7

janpio added platform: ios bug enhancement and removed platform: ios labels Sep 16, 2018

janpio changed the title ~~CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app~~ fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415) Jul 4, 2019

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415) #310

Are you sure you want to change the base?

fix(ios): Importing corrupt images using the Camera plugin crashes the app (CB-13415) #310

Conversation

alpesh12 commented Jan 25, 2018

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

alpesh12 commented Jan 26, 2018

alsorokin commented Jan 26, 2018

alsorokin commented Jan 26, 2018 • edited Loading

shazron Jan 26, 2018

Choose a reason for hiding this comment

alpesh12 Jan 26, 2018

Choose a reason for hiding this comment

shazron commented Jan 27, 2018

jcesarmobile commented Jan 28, 2018

alpesh12 commented Jan 29, 2018 • edited Loading

alpesh12 commented Feb 1, 2018

jcesarmobile commented Feb 1, 2018

jayeshthanki903 commented Feb 13, 2018

LiDhaval commented Feb 19, 2018

alpesh12 commented Feb 22, 2018

LiDhaval commented Feb 28, 2018

ShemrickFlannigan commented Feb 28, 2018

jd0048 commented Mar 5, 2018

alsorokin commented Mar 6, 2018 • edited Loading

alsorokin commented Mar 6, 2018

jd0048 commented Mar 6, 2018

alsorokin commented Mar 6, 2018

jd0048 commented Mar 6, 2018

alsorokin commented Mar 6, 2018

jd0048 commented Mar 6, 2018

alsorokin commented Mar 6, 2018

jd0048 commented Mar 6, 2018

jd0048 commented Mar 6, 2018

alsorokin commented Mar 6, 2018

jd0048 commented Mar 7, 2018

alpesh12 commented Mar 22, 2018

jcesarmobile commented Mar 22, 2018

alpesh12 commented Mar 22, 2018

jcesarmobile commented Mar 22, 2018

alpesh12 commented Mar 22, 2018 • edited Loading

janpio commented Oct 2, 2018

janpio commented Jul 4, 2019

alsorokin commented Jan 26, 2018 •

edited

Loading

alpesh12 commented Jan 29, 2018 •

edited

Loading

alsorokin commented Mar 6, 2018 •

edited

Loading

alpesh12 commented Mar 22, 2018 •

edited

Loading