chore: Make shuffle compression level configurable #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
viirya
approved these changes
Jul 5, 2024
parthchandra
reviewed
Jul 8, 2024
| val COMET_EXEC_SHUFFLE_COMPRESSION_LEVEL: ConfigEntry[Int] = | ||
| conf(s"$COMET_EXEC_CONFIG_PREFIX.shuffle.compressionLevel") | ||
| .doc("Zstd compression level used in shuffle.") | ||
| .intConf |
There was a problem hiding this comment.
Perhaps we could have a check here for valid values?
advancedxy
reviewed
Jul 9, 2024
| @@ -128,27 +128,32 @@ pub struct PhysicalPlanner { | |||
| exec_context_id: i64, | |||
| execution_props: ExecutionProps, | |||
| session_ctx: Arc<SessionContext>, | |||
| compression_level: i32, | |||
There was a problem hiding this comment.
It seems like that we are passing around the compression_level parameters. It's somehow a bit ugly if we are going to add more configurable entries later.
Could we leverage the SessionConf in session_ctx.state to avoid that?
| @@ -80,6 +79,8 @@ pub struct ShuffleWriterExec { | |||
| /// Metrics | |||
| metrics: ExecutionPlanMetricsSet, | |||
| cache: PlanProperties, | |||
| /// zstd compression level | |||
| compression_level: i32, | |||
There was a problem hiding this comment.
If the compression_level is stored in SessionConf, we may retrieve that when executing instead of defining a new field?
core/src/execution/jni_api.rs
Outdated
| @@ -455,6 +466,7 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_writeSortedFileNative | |||
| checksum_enabled: jboolean, | |||
| checksum_algo: jint, | |||
| current_checksum: jlong, | |||
| compression_level: jlong, | |||
There was a problem hiding this comment.
I believe you need to update jni code in the JVM side too: org.apache.comet.Native#writeSortedFileNative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I noticed the comment
// TODO: make compression level configurableso I went ahead and made this change so that we can test the performance impact of different compression levels.What changes are included in this PR?
How are these changes tested?