chore: Remove ObjectHashAggregate from BaseAggregateExec pattern as it is not supported #990
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
force-pushed
the
object_hash_not_supported
branch
2 times, most recently
from
38ec4a7
to
4368957
Compare
…t is not supported
viirya
force-pushed
the
object_hash_not_supported
branch
from
4368957
to
5b59c9c
Compare
|
Close in favor of #991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
It is uncertain if DataFusion hash aggregate operator can replace Spark ObjectHashAggregate. We should disable it from Comet planner until we make sure it works.
What changes are included in this PR?
How are these changes tested?