Warn instead of error for unused imports #12588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
changed the title
|
See samuelcolvin#2 - confirming that CI still fails on unused imports. |
alamb
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Thank you @samuelcolvin
I double checked that the actual CI calls rust_clippy.sh
datafusion/.github/workflows/rust.yml
Line 481 in bd8960e
And then that rust_clippy will error on warnings -D warnings
datafusion/ci/scripts/rust_clippy.sh
Line 21 in bd8960e
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
* warn not error on unused imports * pre-commit error on clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's very frustrating when working on datafusion that unused imports cause scripts and tests to fail at build time, and not run.
Also, while looking in to this, it seems the
pre-commit.shscript wasn't failing when clippy failed.This doesn't affect CI where unused imports will still cause failure I believe.
What changes are included in this PR?
unused_imports = "deny"from the rootCargo.toml, so the default behaviour of warning occurspre-commit.shfail if clippy failsAre these changes tested?
Manually, yes.
Are there any user-facing changes?
No.