LIMIT Push-down logical plan optimization for Extension nodes
#12685
+302
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]> Add rewrite rule for `push-down-limit` for `Extension` Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
github-actions
bot
added
logical-expr
Signed-off-by: Austin Liu <[email protected]>
Dandandan
reviewed
Sep 30, 2024
Signed-off-by: Austin Liu <[email protected]>
goldmedal
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12679.
Rationale for this change
As per issue depicted.
What changes are included in this PR?
Modify
UserDefinedLogicalNodeCore/UserDefinedLogicalNodetraits to check if its safe to push the limit to the children or not, viaallows_limit_to_inputs, and also update the related interfaces.Are these changes tested?
Yes, I've add several tests in
datafusion/optimizer/src/push_down_limit.rs. Please correct me if it's wrong cases or needs more tests.Are there any user-facing changes?
No user-facing changes.
But, interface changed in
UserDefinedLogicalNodeCore/UserDefinedLogicalNodetraits.