HBASE-27900. [HBOSS] Open file fails with NumberFormatException for S3AFileSystem #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iba5e4966f3260ffb132c70bb9490ceb57198f9cc
virajjasani
reviewed
Jun 2, 2023
| /** | ||
| * sets the long value. | ||
| * @since Hadoop-3.3.6 | ||
| * Method added in HADOOP-18274. |
|
|
||
| /** | ||
| * Set optional double parameter for the Builder. | ||
| * @since Hadoop-3.3.6 |
There was a problem hiding this comment.
shall we mention HADOOP-18724 for all comments with @since Hadoop-3.3.6?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the same bug as HADOOP-18724; overloading of setter by different number types can cause problems. This patch converts all supplied double/float args to long before setting -exactly what the hadoop change does.