Completed work for Issue #916 - Conversion to native Array.Empty<T>() #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed ```Lucene.Net.Support.Arrays.Empty<T>()``` and ```FEATURE_ARRAYEMPTY```. Converted all ```Arrays.Empty<T>()``` to ```Array.Empty<T>()``` and added ```using System;``` where required. Removed ```using Lucene.Net.Support;``` statements that were no longer required.
NightOwl888
previously requested changes
Aug 12, 2024
There was a problem hiding this comment.
Thanks for the PR and your willingness to help make our project better.
There are a few changes we would like you to make before we can accept this PR. First, please see the comments inline.
In addition to those changes, this task is to remove FEATURE_ARRAYEMPTY from the codebase. But it still exists in these 2 places. Please remove these lines.
https://github.com/J-Exodus/lucenenet/blob/issue-916/Directory.Build.targets#L55
https://github.com/J-Exodus/lucenenet/blob/issue-916/Directory.Build.targets#L116-L122
src/Lucene.Net.Analysis.Common/Analysis/Query/QueryAutoStopWordAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/Index/IndexFixCommandTest.cs
Outdated
Show resolved
Hide resolved
src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/Index/IndexSplitCommandTest.cs
Outdated
Show resolved
Hide resolved
Rectified Pull request issues as identified by NightOwl888: - Removed to missed references to `FEATURE_ARRAYEMPTY' - Reverted `FieldComparator.cs` back to original state - Corrected sort order for using statements - Reverted indentation on `JavascriptLexer.cs`
|
Thanks for your patience in providing feedback for this PR. I have corrected the issues as identified. This one should now be good to go. |
paulirwin
approved these changes
Aug 13, 2024
paulirwin
dismissed
NightOwl888’s stale review
Changes have been addressed by PR author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion to native Array.Empty()
Fixes #916
Description
This is my first real PR. Always happy for feedback.
Lucene.Net.Support.Arrays.Empty<T>()andFEATURE_ARRAYEMPTY.Arrays.Empty<T>()toArray.Empty<T>()and addedusing System;where required.using Lucene.Net.Support;statements that were no longer required.FieldComparitor.csconvertedMISSING_BTYESandNON_MISSING_BYTEStoArray.Empty<bytes>()Conducted unit tests - all passed. Unsure correct format to attach results.
Unfortunately, my linter has picked up the extra white spaces in the files I updated, which are marked as individual changes. If this effects the ability to review and merge this PR, please let me know and I'll redo it all with the linter off.