Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Antoine Pitrou <[email protected]>
  • Loading branch information
emkornfield and pitrou committed Jul 9, 2024
1 parent 2a8875a commit 4a13c2a
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ The general steps for adding features to the format are as follows:
1. Discuss changes on the developer mailing list ([email protected]).
Often times it is helpful to link to a draft pull request to make the
discussion concrete. This step is complete when there is lazy consensus. Part
of the consensus is whether it sufficient to provide 2 working
implementations as outlined in step 2 or if demonstration of the feature with
a down-stream query engine is necessary to justify the feature (e.g.
demonstrate performance improvements in Arrow's DataSet library or Apache
Data Fusion or another open source engine).
of the consensus is whether it is sufficient to provide two working
implementations as outlined in step 2, or if demonstration of the feature with
a downstream query engine is necessary to justify the feature (e.g.
demonstrate performance improvements in the Apache Arrow C++ Dataset library,
the Apache DataFusion query engine, or any other open source engine).

2. Once a change has lazy consensus, two implementations of the feature
demonstrating interopability must also be provided. One implementation MUST
Expand All @@ -58,7 +58,7 @@ The general steps for adding features to the format are as follows:
of the PMC any open source Parquet implementation may be acceptable.
Implementations whose contributors actively participate in the community
(e.g. keep their feature matrix up-to-date on the Parquet website) are more
likely to be considered. If discussed as a requirement in step one,
likely to be considered. If discussed as a requirement in step 1 above,
demonstration of integration with a query engine is also required for this
step. The implementations must be made available publicly, and they should be
fit for inclusion (for example, they were submitted as a pull request against
Expand Down

0 comments on commit 4a13c2a

Please sign in to comment.